Skip to content

Extend wallet::export module to also import/export the Caravan wallet format #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
notmandatory opened this issue Apr 19, 2022 · 5 comments · May be fixed by #205
Open

Extend wallet::export module to also import/export the Caravan wallet format #5

notmandatory opened this issue Apr 19, 2022 · 5 comments · May be fixed by #205
Assignees
@vkprogrammer-001
Labels
good first issue Good for newcomers new feature New feature or request

Comments

@notmandatory
Copy link
Member

notmandatory commented Apr 19, 2022 •
edited
Loading

Currently the wallet::export module can import and export the wallet format used by FullyNoded.

In order to support users of the Caravan multisig coordinator and to possibly migrate that project to using a WASM build of BDK we should add support for importing and exporting the Caravan wallet config json file format.

Note, the descriptor::policy module should be able to supply all of the bdk wallet descriptor information needed to create a caravan wallet config file.
@notmandatory notmandatory self-assigned this Apr 19, 2022
@notmandatory
Copy link
Member Author

@bucko13 is there a spec or docs describing the caravan config file format out there somewhere? If not it's ok, I've already managed to reverse engineer it well enough to create an equivalent descriptor but I want to make sure I'm not missing anything.

@bucko13
Copy link
Contributor

bucko13 commented Apr 19, 2022

No spec, no. In the true spirit of bitcoin, the json is the spec 😅

@afilini
Copy link
Member

afilini commented Apr 19, 2022

I've opened bitcoindevkit/bdk#589 to deprecate WalletExport and rename it to FullyNodedExport. I think we should have time to get this into the next release which will be published in a few days, so in the following one we can completely remove WalletExport to avoid causing confusion.

@bucko13
Copy link
Contributor

bucko13 commented Apr 19, 2022

Nice!

@notmandatory notmandatory added the good first issue Good for newcomers label Mar 27, 2025
@notmandatory notmandatory moved this to Todo in BDK Wallet Mar 27, 2025
@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Apr 3, 2025
@notmandatory notmandatory added the new feature New feature or request label Apr 4, 2025
@vkprogrammer-001
Copy link

Hey, @notmandatory. Can I take this issue?

@vkprogrammer-001 vkprogrammer-001 linked a pull request Apr 9, 2025 that will close this issue
Open
3 tasks
@notmandatory notmandatory moved this from Todo to In Progress in BDK Wallet Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkprogrammer-001 vkprogrammer-001

Labels
good first issue Good for newcomers new feature New feature or request
Projects
BDK Wallet
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add Caravan wallet format import/export support vkprogrammer-001/bdk_wallet
4 participants
@afilini @bucko13 @notmandatory @vkprogrammer-001