Skip to content

Randomize anti-fee sniping height #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notmandatory opened this issue Nov 14, 2024 · 1 comment · May be fixed by #207
Open

Randomize anti-fee sniping height #47

notmandatory opened this issue Nov 14, 2024 · 1 comment · May be fixed by #207
Labels
audit Suggested as result of external code audit

Comments

@notmandatory
Copy link
Member

"When possible to use anti fee-sniping, you always set the current height. All implementations of anti fee-sniping i'm aware of randomize this by sometimes using a much lower height (typically 100 less) to avoid consistently giving up the height at which a transaction was crafted. I'm not sure how useful this randomization is, but you might want to consider it. Especially as you already have a RNG at hand in this function."

@notmandatory notmandatory added the audit Suggested as result of external code audit label Nov 14, 2024
@notmandatory notmandatory moved this to Discussion in BDK Wallet Nov 14, 2024
@aagbotemi
Copy link

aagbotemi commented Mar 21, 2025

Hi @notmandatory

The description of randomizing anti-fee sniping height is mentioned in BIP326. Do we want to limit anti-fee sniping height to only taproot transaction or we implement it for all transactions?

@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Apr 7, 2025
@aagbotemi aagbotemi linked a pull request Apr 12, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Suggested as result of external code audit
Projects
Status: Discussion
Development

Successfully merging a pull request may close this issue.

2 participants