You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge #94: fix(ci): pin tokio to 1.38.1 on MSRV step
16cdd38 fix(ci): pin tokio to 1.38.1 on msrv step (Leonardo Lima)
Pull request description:
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### Description
As previously noticed on bitcoindevkit/bdk#1524, tokio raised their MSRV to `1.70.0` in their latest release, in short it was because they moved to `mio 1.0` which requires `1.70.0` MSRV.
Although we don't have `tokio` as a direct dependency on `rust-esplora-client` it comes as a transitive dependency from `reqwest`.
This PR adds the necessary pinning on CI and updates the instruction on `README.md` in order to properly build on MSRV.
<!-- Describe the purpose of this PR, what's being adding and/or fixed -->
### Notes to the reviewers
<!-- In this section you can include notes directed to the reviewers, like explaining why some parts
of the PR were done in a specific way -->
### Changelog notice
- Adds another MSRV pinning step on CI for the `tokio 1.38.1`.
<!-- Notice the release manager should include in the release tag message changelog -->
<!-- See https://keepachangelog.com/en/1.0.0/ for examples -->
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
<!--
#### New Features:
* [ ] I've added tests for the new feature
* [ ] I've added docs for the new feature
#### Bugfixes:
* [ ] This pull request breaks the existing API
* [ ] I've added tests to reproduce the issue which are now passing
* [ ] I'm linking the issue being fixed by this PR
-->
ACKs for top commit:
notmandatory:
ACK 16cdd38
Tree-SHA512: 3b98bc96ff797b67bcec215bc957561698e06c74d4184780aff4d129630f2216f2aa415a0042f3551a9d6197d6aa376cb540daf2a5ead996f4ba20b1674e4215
0 commit comments