Skip to content

WS2Manager swallows socket.open/auth errors #565

@adrian-gierakowski

Description

@adrian-gierakowski

Issue type

  • bug
  • missing functionality
  • performance
  • feature request

Brief description

I believe the following 2 errors should be emitted by the WS2Manager instead of just being logged:

ws.open().then(() => {
return debug('socket connection opened')
}).catch((err) => {
debug('error opening socket: %s', err.stack)
})

ws.auth().then(() => {
return debug('socket authenticated')
}).catch((err) => {
debug('error authenticating socket: %s', err.message)
})
})

Steps to reproduce

Start WS2Manager with an invalid url (api.bitfinex.com/ws/2 instead of wss://api.bitfinex.com/ws/2) and try to subscribe to one of the channel (for example call subscribeTicker('tBTCUSD').

Additional Notes:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions