Skip to content

Commit 1b1808e

Browse files
committed
Require Twisted>=18.7.0
Recent treq requires Twisted 18.7.0. Additionally, on python3.9 unit tests are no longer working when using Twisted 17.9. It's simplier to upgrade to a new Twisted than to investigate how to support so old Twisted versions.
1 parent 5a55b28 commit 1b1808e

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.bbtravis.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ matrix:
4545
# include "ci" string into the name of the status that is eventually submitted to Github, so
4646
# that the codecov.io service would wait until this build is finished before creating report.
4747
- python: "3.9"
48-
env: TWISTED=17.9.0 SQLALCHEMY=latest TESTS=trial
48+
env: TWISTED=18.7.0 SQLALCHEMY=latest TESTS=trial
4949
- python: "3.7"
5050
env: TWISTED=latest SQLALCHEMY=latest TESTS=ci/coverage
5151
- python: "3.8"
@@ -73,7 +73,7 @@ matrix:
7373
# Worker tests on python and twisted package combinations.
7474
# We support worker on Python 2.7, on which Twisted 20.3.0 is the last version that works
7575
- python: "3.9"
76-
env: TWISTED=17.9.0 SQLALCHEMY=latest TESTS=trial_worker
76+
env: TWISTED=18.7.0 SQLALCHEMY=latest TESTS=trial_worker
7777
- python: "2.7"
7878
env: TWISTED=20.3.0 SQLALCHEMY=latest TESTS=trial_worker
7979

master/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ def define_plugin_entries(groups):
484484
if parse_version(pip_dist.version) < parse_version('1.4'):
485485
raise RuntimeError(VERSION_MSG)
486486

487-
twisted_ver = ">= 17.9.0"
487+
twisted_ver = ">= 18.7.0"
488488
autobahn_ver = ">= 0.16.0"
489489
txaio_ver = ">= 2.2.2"
490490

newsfragments/twisted-new-dep.removal

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
``buildbot`` package now requires Twisted versions >= 18.7.0

worker/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def make_release_tree(self, base_dir, files):
144144
if sys.platform == "win32":
145145
setup_args['zip_safe'] = False
146146

147-
twisted_ver = ">= 17.9.0"
147+
twisted_ver = ">= 18.7.0"
148148

149149
if setuptools is not None:
150150
setup_args['install_requires'] = [

0 commit comments

Comments
 (0)