Fix group sorting & adjust tests average column width #387

hupf · hupf · commit 3b08aef9ae33 · 2025-03-10T16:35:44.000+01:00
diff --git a/src/app/events/components/test-edit-grades/test-edit-grades-common.scss b/src/app/events/components/test-edit-grades/test-edit-grades-common.scss
@@ -16,7 +16,7 @@
   --student-grade-column-width: calc(
     var(--spacer) + var(--grade-input-size) + var(--spacer)
   );
-  --student-average-column-width: 100px;
+  --student-average-column-width: 120px;
   --test-grade-column-width: calc(
     var(--spacer) + var(--point-input-size) + var(--points-grade-gap) +
       var(--grade-input-size) + var(--spacer)
diff --git a/src/app/presence-control/utils/subscriptions-details.ts b/src/app/presence-control/utils/subscriptions-details.ts
@@ -33,7 +33,7 @@ function getSubscriptionDetailComparator(
         const valueA = a.detail.Value ? String(a.detail.Value) : "";
         const valueB = b.detail.Value ? String(b.detail.Value) : "";
         const groupComparator = valueA.localeCompare(valueB);
-        return sortCriteria.ascending ? groupComparator * -1 : groupComparator;
+        return sortCriteria.ascending ? groupComparator : groupComparator * -1;
       }
       default:
         throw new UnreachableError(

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function getSubscriptionDetailComparator(`
`33`	`33`	`const valueA = a.detail.Value ? String(a.detail.Value) : "";`
`34`	`34`	`const valueB = b.detail.Value ? String(b.detail.Value) : "";`
`35`	`35`	`const groupComparator = valueA.localeCompare(valueB);`
`36`		`- return sortCriteria.ascending ? groupComparator * -1 : groupComparator;`
	`36`	`+ return sortCriteria.ascending ? groupComparator : groupComparator * -1;`
`37`	`37`	`}`
`38`	`38`	`default:`
`39`	`39`	`throw new UnreachableError(`