Normalize update settings route matching

Author: mcharles-square

client/src/protoFleet/features/updates/useUpdateIndicator.test.tsx

@@ -48,16 +48,19 @@ describe("useUpdateIndicator", () => {
     expect(vi.mocked(useAvailableUpdate)).toHaveBeenLastCalledWith({ enabled: false });
   });
 
-  it("does not poll or render on the authoritative settings page", () => {
-    render(
-      <MemoryRouter initialEntries={["/settings/updates"]}>
-        <Harness />
-      </MemoryRouter>,
-    );
-
-    expect(screen.queryByRole("button", { name: /Update v/ })).not.toBeInTheDocument();
-    expect(vi.mocked(useAvailableUpdate)).toHaveBeenCalledWith({ enabled: false });
-  });
+  it.each(["/settings/updates", "/settings/updates/"])(
+    "does not poll or render on the authoritative settings page at %s",
+    (pathname) => {
+      render(
+        <MemoryRouter initialEntries={[pathname]}>
+          <Harness />
+        </MemoryRouter>,
+      );
+
+      expect(screen.queryByRole("button", { name: /Update v/ })).not.toBeInTheDocument();
+      expect(vi.mocked(useAvailableUpdate)).toHaveBeenCalledWith({ enabled: false });
+    },
+  );
 
   it("does not render when the shell disables the indicator", () => {
     render(

client/src/protoFleet/features/updates/useUpdateIndicator.ts

@@ -18,7 +18,8 @@ interface UseUpdateIndicatorOptions {
 export function useUpdateIndicator({ enabled = true }: UseUpdateIndicatorOptions = {}): UpdatePillData | null {
   const navigate = useNavigate();
   const { pathname } = useLocation();
-  const availableVersion = useAvailableUpdate({ enabled: enabled && pathname !== UPDATE_SETTINGS_PATH });
+  const isUpdateSettingsPath = pathname.replace(/\/+$/, "") === UPDATE_SETTINGS_PATH;
+  const availableVersion = useAvailableUpdate({ enabled: enabled && !isUpdateSettingsPath });
 
   const openUpdateSettings = useCallback(() => {
     void navigate(UPDATE_SETTINGS_PATH);