Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes #2015

Open
7 tasks
gorkem-bwl opened this issue Mar 28, 2025 · 9 comments
Open
7 tasks

Translation fixes #2015

gorkem-bwl opened this issue Mar 28, 2025 · 9 comments

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Mar 28, 2025

  • Change "Sign up via email" to "Create super admin account"
  • Change to "By signing up, you..." "By creating an account, you agree to our Terms of Service and Privacy Policy" (this string should be in one, translatable sentence as a whole, like By signing up, you agree to our <a href="...">Terms of Service</a> and <a href="...">Privacy Policy</a>.

Image

  • Name and surname should be translatable

Image

  • Cover edge cases with names from various languages and scripts.

Here is a regex for this: ^[\p{L}\p{M}'’- ]+$`

  • \p{L}: Matches any kind of letter from any language.
  • \p{M}: Matches a combining mark (used for diacritics and accents).
  • '’-`: Allows common punctuation characters used in names (apostrophes, typographic apostrophes, hyphens).
  • : Allows spaces.
  • +: Ensures that one or more characters are present.
  • Anchors ^ and $: Ensure that the entire string follows the pattern.

Image

  • "Email" and "Email is required" should be translatable

Image

  • Instead of "Password", use "Enter your password"

Image

  • Change "Create a password" string to "Create your password"
@gorkem-bwl gorkem-bwl added this to the 2.1 (Ship of Theseus) milestone Mar 28, 2025
@ceskyDJ
Copy link

ceskyDJ commented Mar 28, 2025

@gorkem-bwl, thanks for kicking up an issue related to these problems! As I look at it, I see that a few issues have disappeared with time, so please let me reintroduce them here.

  • In general, many strings can’t be translated (those @gorkem-bwl put into the description are just a few I could find in a few minutes of translating). I’d recommend making an “audit” of all UI strings to find as many untranslatable strings as possible so the translator doesn’t have to post many related issues.
  • Someone should go through the UI and fix the inconsistent naming of things (as you can see in the description of this issue in the onboarding process). Simply said, one thing/action should be named the same or at least very close, so there isn’t a space for confusion on the user’s side.
  • There are a lot of partial strings (like “By signing up, you agree to our”—our what, potatoes?). It’s essential to have the strings (or at least sentences, but be warned, that shouldn’t be enough when you reuse these sentences in different contexts) in a complete way, as there are some languages (like Czech) where it can completely change the valid translation when you add something else to the base part. So, all of these partial strings should be replaced by complete variants. In this case, it should be something like By signing up, you agree to our <a href="...">Terms of Service</a> and <a href="...">Privacy Policy</a>. (or, e.g., use Markdown or some other technique for links and these special scenarios).
  • There are almost the same few strings without additional context (e.g., “Create a password” and “Create your password”). If it’s necessary to have these two variants, you need to provide context for translators (e.g., add a screenshot to POEditor).

@gorkem-bwl
Copy link
Contributor Author

Thanks. I am good with your suggestions and modified the first issue regarding your third suggestion.

There are almost the same few strings without additional context (e.g., “Create a password” and “Create your password”). If it’s necessary to have these two variants, you need to provide context for translators (e.g., add a screenshot to POEditor).

For this one, I am not sure I follow. Create a password and Create your password are two sentences that are relatively easy to translate 1-1. What kind of context do we need here so the translator won't be confused?

@ceskyDJ

This comment has been minimized.

@gorkem-bwl
Copy link
Contributor Author

The problem is not the context but potential duplication IMHO.

When I change one of the strings to the other one, would that resolve your point? Or do you still need a context for "Create your password" ?

@ceskyDJ

This comment has been minimized.

@gorkem-bwl
Copy link
Contributor Author

OK, then I will merge them into one (Create your password).

@ceskyDJ

This comment has been minimized.

@ceskyDJ

This comment has been minimized.

@gorkem-bwl
Copy link
Contributor Author

Sure, I can do. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants