clippy

Author: zeitlinger

client/src/client.rs

@@ -24,9 +24,7 @@ use crate::player_ui::{show_global_controls, show_globals, show_resources, show_
 use crate::{combat_ui, influence_ui, move_ui, recruit_unit_ui, status_phase_ui};
 
 pub async fn init(features: &Features) -> State {
-    let state = State::new(features).await;
-
-    state
+    State::new(features).await
 }
 
 pub fn render_and_update(

client/src/client_state.rs

@@ -118,6 +118,12 @@ pub struct StateUpdates {
     updates: Vec<StateUpdate>,
 }
 
+impl Default for StateUpdates {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl StateUpdates {
     pub fn new() -> StateUpdates {
         StateUpdates { updates: vec![] }
@@ -167,13 +173,15 @@ impl State {
         self.pending_update = None;
     }
 
+    #[must_use]
     pub fn is_collect(&self) -> bool {
         if let ActiveDialog::CollectResources(_c) = &self.active_dialog {
             return true;
         }
         false
     }
 
+    #[must_use]
     pub fn has_dialog(&self) -> bool {
         !matches!(self.active_dialog, ActiveDialog::None)
     }
@@ -301,6 +309,7 @@ impl State {
     }
 }
 
+#[must_use]
 pub fn can_play_action(game: &Game) -> bool {
     game.state == GameState::Playing && game.actions_left > 0
 }

client/src/lib.rs

@@ -4,7 +4,8 @@
     clippy::cast_precision_loss,
     clippy::cast_sign_loss,
     clippy::cast_possible_wrap,
-    clippy::cast_possible_truncation
+    clippy::cast_possible_truncation,
+    clippy::missing_panics_doc
 )]
 
 mod advance_ui;

client/src/remote_client/bin/main.rs

@@ -95,7 +95,7 @@ impl RemoteClient {
         if s.is_object() {
             log("received state");
             let game1 = Game::from_data(
-                serde_wasm_bindgen::from_value(s.into()).expect("game should be of type game data"),
+                serde_wasm_bindgen::from_value(s).expect("game should be of type game data"),
             );
             self.game = Some(game1);
             self.state = RemoteClientState::Playing;