Allow recursive assignment of default values to complex properties #54
+227
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
property-defaults
branch
from
95d3c21 to
059028b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not strictly mandated by JSON-schema, it is common practice that property default values support arbitrarily nested JSON objects. This PR rearranges the default constructor code generator to support recursive assignment of default values in cases where the default value is an arbitrary JSON object.
It does this by piggybacking on provided JSON schema definitions for the model object properties, and abusing the
ValueGenerator.GetDefaultValueto obtain valid code snippets for primitive property assignments.Fixes #41