Skip to content

Commit 0216122

Browse files
sunwon12sunwon12
committed
[Refactor] 전체 파일들 checkstyle 적용
1 parent 805a392 commit 0216122

118 files changed

Lines changed: 3197 additions & 4382 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎config/checkstyle/checkstyle-suppressions.xml‎

Lines changed: 0 additions & 144 deletions
Original file line numberDiff line numberDiff line change
@@ -9,156 +9,12 @@
99
리팩토링 완료된 파일은 이 목록에서 제거해주세요.
1010
-->
1111
<suppressions>
12-
<!-- === bestseller === -->
13-
<suppress checks=".*" files="BestsellerService\.java"/>
14-
15-
<!-- === book === -->
16-
<suppress checks=".*" files="BookCategoryService\.java"/>
17-
<suppress checks=".*" files="BookLikeApi\.java"/>
18-
<suppress checks=".*" files="LikedBookResponse\.java"/>
19-
<suppress checks=".*" files="BookLikeRepositoryCustom\.java"/>
20-
<suppress checks=".*" files="BookLikeService\.java"/>
21-
<suppress checks=".*" files="BookOverviewResponse\.java"/>
22-
<suppress checks=".*" files="BookRecommendationScheduler\.java"/>
23-
<suppress checks=".*" files="BookSaveService\.java"/>
24-
<suppress checks=".*" files="BookService\.java"/>
25-
<suppress checks=".*" files="ChapterRepositoryImpl\.java"/>
26-
<suppress checks=".*" files="ChapterService\.java"/>
27-
2812
<!-- === challenge === -->
29-
<suppress checks=".*" files="ChallengeSucessDetail\.java"/>
30-
<suppress checks=".*" files="CommentHierarchy\.java"/>
31-
<suppress checks=".*" files="DiaryComment\.java"/>
32-
<suppress checks=".*" files="DiaryCommentService\.java"/>
33-
<suppress checks=".*" files="DiaryDetailCombiner\.java"/>
34-
<suppress checks=".*" files="DiaryImageResponse\.java"/>
35-
<suppress checks=".*" files="DiaryResponse\.java"/>
36-
<suppress checks=".*" files="FeedLockService\.java"/>
37-
<suppress checks=".*" files="FeedService\.java"/>
38-
<suppress checks=".*" files="LikedDiaryResponse\.java"/>
39-
<suppress checks=".*" files="PopularDiaryFeedManager\.java"/>
40-
<suppress checks=".*" files="PopularityScoreScheduler\.java"/>
41-
<suppress checks=".*" files="ReadingDiary\.java"/>
42-
<suppress checks=".*" files="ReadingDiaryController\.java"/>
43-
<suppress checks=".*" files="ReadingDiaryLikeRepositoryImpl\.java"/>
44-
<suppress checks=".*" files="ReadingDiaryRepositoryCustom\.java"/>
45-
<suppress checks=".*" files="ReadingDiaryRepositoryImpl\.java"/>
46-
<suppress checks=".*" files="ReadingDiaryScrapRepositoryImpl\.java"/>
47-
<suppress checks=".*" files="ReadingDiaryService\.java"/>
48-
<suppress checks=".*" files="ReadingDiaryStatisticCacheRepository\.java"/>
49-
<suppress checks=".*" files="ReadingProgressService\.java"/>
50-
<suppress checks=".*" files="RedisFeedBucketRepository\.java"/>
51-
<suppress checks=".*" files="StatisticsRecoverBatchProcessor\.java"/>
52-
<suppress checks=".*" files="StatisticsRecoveryService\.java"/>
53-
<suppress checks=".*" files="V2ChallengeService\.java"/>
54-
55-
<!-- === chat === -->
56-
<suppress checks=".*" files="ChatMessageService\.java"/>
5713

5814
<!-- === common === -->
59-
<suppress checks=".*" files="AsyncMetricsAspect\.java"/>
60-
<suppress checks=".*" files="CustomAsyncExceptionHandler\.java"/>
61-
<suppress checks=".*" files="DiscordMessageGenerator\.java"/>
62-
<suppress checks=".*" files="DistributedLockAop\.java"/>
6315
<suppress checks=".*" files="DualCursorPageResponse\.java"/>
64-
<suppress checks=".*" files="RedissonLockExecutor\.java"/>
65-
<suppress checks=".*" files="SenderToDiscord\.java"/>
6616

6717
<!-- === crawler === -->
68-
<suppress checks=".*" files="AdminAladinCrawlerManualService\.java"/>
69-
<suppress checks=".*" files="AdminBlogCrawlerController\.java"/>
70-
<suppress checks=".*" files="AladinCrawlerBatchProcessor\.java"/>
71-
<suppress checks=".*" files="AladinCrawlerService\.java"/>
72-
<suppress checks=".*" files="AladinHtmlValidationScheduler\.java"/>
73-
<suppress checks=".*" files="CrawlPersistenceService\.java"/>
74-
<suppress checks=".*" files="NaverBlogCrawlingStrategy\.java"/>
75-
<suppress checks=".*" files="NaverBlogPostCrawlingStrategy\.java"/>
76-
<suppress checks=".*" files="NaverBlogPostService\.java"/>
77-
<suppress checks=".*" files="NaverBlogService\.java"/>
78-
<suppress checks=".*" files="NaverSearchService\.java"/>
79-
80-
<!-- === image === -->
81-
<suppress checks=".*" files="AwsS3ImageService\.java"/>
82-
83-
<!-- === mail === -->
84-
<suppress checks=".*" files="ReportEmailContentBuilder\.java"/>
85-
86-
<!-- === member === -->
87-
<suppress checks=".*" files="BlockService\.java"/>
88-
<suppress checks=".*" files="DeleteMemberService\.java"/>
89-
<suppress checks=".*" files="MemberRedisRepository\.java"/>
90-
<suppress checks=".*" files="MemberService\.java"/>
91-
<suppress checks=".*" files="Policy\.java"/>
92-
<suppress checks=".*" files="ProfileResponse\.java"/>
93-
94-
<!-- === motive === -->
95-
<suppress checks=".*" files="KnowledgeFusionService\.java"/>
96-
97-
<!-- === music === -->
98-
<suppress checks=".*" files="MusicResponse\.java"/>
99-
100-
<!-- === notification === -->
101-
<suppress checks=".*" files="FirebaseClient\.java"/>
102-
<suppress checks=".*" files="NotificationDeviceLog\.java"/>
103-
<suppress checks=".*" files="NotificationDto\.java"/>
104-
<suppress checks=".*" files="NotificationMessageFactory\.java"/>
105-
<suppress checks=".*" files="NotificationService\.java"/>
106-
107-
<!-- === onboarding === -->
108-
<suppress checks=".*" files="OnboardingService\.java"/>
10918

11019
<!-- === quiz === -->
111-
<suppress checks=".*" files="GeminiBookRecommendationProvider\.java"/>
112-
<suppress checks=".*" files="GeminiClientManager\.java"/>
113-
<suppress checks=".*" files="GeminiQuizPromptProvider\.java"/>
114-
<suppress checks=".*" files="GeminiQuizResponse\.java"/>
115-
<suppress checks=".*" files="GeminiQuizResponses\.java"/>
116-
<suppress checks=".*" files="GeminiRateLimiterService\.java"/>
117-
<suppress checks=".*" files="GeminiSdkClient\.java"/>
118-
<suppress checks=".*" files="GeminiTokenTracker\.java"/>
119-
<suppress checks=".*" files="GeminiTokenUsage\.java"/>
120-
<suppress checks=".*" files="QuizAdminService\.java"/>
121-
<suppress checks=".*" files="QuizAlertService\.java"/>
122-
<suppress checks=".*" files="QuizAttempt\.java"/>
123-
<suppress checks=".*" files="QuizController\.java"/>
124-
<suppress checks=".*" files="QuizEventListener\.java"/>
125-
<suppress checks=".*" files="QuizGenerationService\.java"/>
126-
<suppress checks=".*" files="QuizResponses\.java"/>
127-
<suppress checks=".*" files="QuizSaveService\.java"/>
128-
<suppress checks=".*" files="QuizService\.java"/>
129-
<suppress checks=".*" files="QuizSubmissionService\.java"/>
130-
<suppress checks=".*" files="QuizSubmitResponse\.java"/>
131-
<suppress checks=".*" files="V2ChallengeResponse\.java"/>
132-
133-
<!-- === ranking === -->
134-
<suppress checks=".*" files="RankingRedisRepository\.java"/>
135-
<suppress checks=".*" files="RankingResponse\.java"/>
136-
<suppress checks=".*" files="RankingService\.java"/>
137-
<suppress checks=".*" files="RankingShardingService\.java"/>
138-
139-
<!-- === report === -->
140-
<suppress checks=".*" files="Report\.java"/>
141-
<suppress checks=".*" files="ReportService\.java"/>
142-
143-
<!-- === search === -->
144-
<suppress checks=".*" files="AladinService\.java"/>
145-
<suppress checks=".*" files="SearchHistoryDbService\.java"/>
146-
<suppress checks=".*" files="SearchService\.java"/>
147-
<suppress checks=".*" files="UserSearchHistoryRepositoryImpl\.java"/>
148-
<suppress checks=".*" files="UserSearchHistoryResponse\.java"/>
149-
150-
<!-- === security === -->
151-
<suppress checks=".*" files="JwtService\.java"/>
152-
153-
<!-- === statistics === -->
154-
<suppress checks=".*" files="ReadingStatisticsService\.java"/>
155-
156-
<!-- === timer === -->
157-
<suppress checks=".*" files="TimerService\.java"/>
158-
159-
<!-- === youtube === -->
160-
<suppress checks=".*" files="MemberPreferenceService\.java"/>
161-
<suppress checks=".*" files="YouTubeClient\.java"/>
162-
<suppress checks=".*" files="YouTubeDataScheduler\.java"/>
163-
<suppress checks=".*" files="YouTubeVideo\.java"/>
16420
</suppressions>

‎config/checkstyle/checkstyle.xml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,13 @@
1616
<property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
1717
</module>
1818

19+
<!-- @SuppressWarnings("checkstyle:...") 지원 -->
20+
<module name="SuppressWarningsFilter"/>
21+
1922
<module name="TreeWalker">
2023

24+
<module name="SuppressWarningsHolder"/>
25+
2126
<!-- 규칙 1: 메서드 길이 15줄 이하 -->
2227
<module name="MethodLength">
2328
<property name="max" value="15"/>
@@ -35,10 +40,11 @@
3540
<property name="max" value="1"/>
3641
</module>
3742

38-
<!-- 규칙 10: 파라미터 3개 이하 -->
43+
<!-- 규칙 10: 메서드 파라미터 3개 이하 (생성자/레코드는 데이터 구조 특성상 면제) -->
3944
<module name="ParameterNumber">
4045
<property name="max" value="3"/>
4146
<property name="ignoreOverriddenMethods" value="true"/>
47+
<property name="tokens" value="METHOD_DEF"/>
4248
</module>
4349

4450
</module>

0 commit comments

Comments
 (0)