Skip to content

Commit f8e8458

Browse files
committed
Fix unused t *testing.T in waitForResourceCreation
Signed-off-by: Andreas Karis <[email protected]>
1 parent 5b21b6f commit f8e8458

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/lifecycle/lifecycle_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func TestLifecycle(t *testing.T) {
127127

128128
// Make sure that all resources are there at the start.
129129
t.Logf("Running: waitForResourceCreation and waitForAvailable")
130-
if err := waitForResourceCreation(ctx, t); err != nil {
130+
if err := waitForResourceCreation(ctx); err != nil {
131131
t.Fatalf("Failed to ensure resources: %q", err)
132132
}
133133
if err := waitForAvailable(ctx); err != nil {
@@ -225,7 +225,7 @@ func testResourceDeletion(ctx context.Context, t *testing.T) error {
225225
if err := runtimeClient.Delete(ctx, obj); err != nil {
226226
return fmt.Errorf("could not delete obj %v, err: %w", obj, err)
227227
}
228-
if err := waitForResourceCreation(ctx, t); err != nil {
228+
if err := waitForResourceCreation(ctx); err != nil {
229229
return err
230230
}
231231
}
@@ -497,7 +497,7 @@ func testConfigCreation(ctx context.Context, t *testing.T, newConfig *v1alpha1.C
497497
}
498498

499499
// Wait for resources to be recreated with new configuration.
500-
if err := waitForResourceCreation(ctx, t); err != nil {
500+
if err := waitForResourceCreation(ctx); err != nil {
501501
return fmt.Errorf("failed to wait for resource creation: %v", err)
502502
}
503503

@@ -540,7 +540,7 @@ func testOperatorPodHealthy(ctx context.Context) error {
540540
// waitForResourceCreation polls for all required bpfman resources to be created and ready.
541541
// Checks for CSI driver, ConfigMap, and both DaemonSets (bpfman and metrics proxy).
542542
// Returns error if timeout is reached or if context is cancelled.
543-
func waitForResourceCreation(ctx context.Context, t *testing.T) error {
543+
func waitForResourceCreation(ctx context.Context) error {
544544
return waitUntilCondition(ctx, func() (bool, error) {
545545
// Check CSI driver exists.
546546
csiDriver := &storagev1.CSIDriver{}

0 commit comments

Comments
 (0)