Is there a way to disable the automatic logging added by this package for "Job Processing" and "Job Processed" ?

[vesper8]

I noticed ever since I added this package that my log file becomes filled with Job Processing and Job Processed for all of my queued jobs, including whenever I broadcast an event. I was surprised to not find an entry in the config file to disable this behaviour? Am I missing something?

[mnapoli]

Hi! I don't think you're missing anything, this could be great to have an option, like for #143

[tillkruss]

Should we maybe add a bref.log_level option so it's configureable and documented?

[mnapoli]

That sounds like a good idea!

[tillkruss]

@vesper8 Feel like submitting a PR?

[vesper8]

Sure : )

Here you go #147

Please don't ask me to write tests for this :-/

[tillkruss]

Thanks @vesper8, I think we need to talk this out internally, but we'll have a solution in a few days 👍

[camilord]

is the config to disable the logging implemented yet?

i have the same issue. the log info is just massive in cloudwatch and unmanageable.

[MightySepp666]

@tillkruss the massive amount of logging is increasing our CloudWatch logs costs significantly (we have hundreds of millions of requests and job executions per month). It does not really provide any meaningful information but pollutes the logs. Please allow this to be switched off (a simple switch option is sufficient for me).

[mnapoli]

@MightySepp666 can you please send a PR (see #147 for a base).

[MightySepp666]

Hi @mnapoli, thank's for the great work you're doing here. I appreciate it and will try to put this on our board.

I've read through the discussion in the mentioned PR, but it seemed to me that no consensus had yet been found on how to implement this (sorry if I missed that part). So could you maybe point me to the way, how you would like this to be implemented? I personally feel, like this logging should rather be of type "debug", but I'm ok with making the level configurable.

[mnapoli]

@MightySepp666 just log_jobs with true/false should be enough: #147 (comment)

[MightySepp666]

Hi @mnapoli sorry for the long delay, but I was occupied with other important projects. As desired, I opened a new PR (#170) based on the works of @vesper8, but with a single log_jobs setting instead.

As the only reason I could see for enabling it, is for debugging purposes, I would like to disable it by default. I don't consider logging a breaking change, so I believe this should be safe.

Personally, I think, that this code shouldn't be part of the Bref-Laravel integration, because it doesn't really handle any Bref or Lambda specifics. It's just job execution in general. But I don't mind, as long as I can control it.

If you want any changes, please let me know. I also wanted to add a test case for it, but this project doesn't have a test setup yet. And it seemed a bit out of scope for this issue to introduce a testing setup first.

[mnapoli]

@MightySepp666 thanks just reviewed 👍