fix: context menu flags/location being ignored

Author: brenocq

implot3d.cpp

@@ -1253,11 +1253,13 @@ bool BeginPlot(const char* title_id, const ImVec2& size, ImPlot3DFlags flags) {
     plot.ID = ID;
     plot.JustCreated = just_created;
     if (just_created) {
-        plot.Flags = flags;
         plot.Rotation = init_rotation;
         for (int i = 0; i < 3; i++)
             plot.Axes[i] = ImPlot3DAxis();
     }
+    if (plot.PreviousFlags != flags)
+        plot.Flags = flags;
+    plot.PreviousFlags = flags;
     plot.SetupLocked = false;
     plot.OpenContextThisFrame = false;
 
@@ -1382,7 +1384,9 @@ void SetupAxis(ImAxis3D idx, const char* label, ImPlot3DAxisFlags flags) {
     // Get plot and axis
     ImPlot3DPlot& plot = *gp.CurrentPlot;
     ImPlot3DAxis& axis = plot.Axes[idx];
-    axis.Flags = flags;
+    if (axis.PreviousFlags != flags)
+        axis.Flags = flags;
+    axis.PreviousFlags = flags;
     axis.SetLabel(label);
 }
 
@@ -1420,8 +1424,12 @@ void SetupLegend(ImPlot3DLocation location, ImPlot3DLegendFlags flags) {
     IM_ASSERT_USER_ERROR(gp.CurrentItems != nullptr,
                          "SetupLegend() needs to be called within an itemized context!");
     ImPlot3DLegend& legend = gp.CurrentItems->Legend;
-    legend.Location = location;
-    legend.Flags = flags;
+    if (legend.PreviousLocation != location)
+        legend.Location = location;
+    legend.PreviousLocation = location;
+    if (legend.PreviousFlags != flags)
+        legend.Flags = flags;
+    legend.PreviousFlags = flags;
 }
 
 //-----------------------------------------------------------------------------

implot3d_internal.h

@@ -303,17 +303,19 @@ struct ImPlot3DItem {
 // Holds legend state
 struct ImPlot3DLegend {
     ImPlot3DLegendFlags Flags;
+    ImPlot3DLegendFlags PreviousFlags;
     ImPlot3DLocation Location;
+    ImPlot3DLocation PreviousLocation;
     ImVector<int> Indices;
     ImGuiTextBuffer Labels;
     ImRect Rect;
     bool Hovered;
     bool Held;
 
     ImPlot3DLegend() {
-        Flags = ImPlot3DLegendFlags_None;
+        PreviousFlags = Flags = ImPlot3DLegendFlags_None;
         Hovered = Held = false;
-        Location = ImPlot3DLocation_NorthWest;
+        PreviousLocation = Location = ImPlot3DLocation_NorthWest;
     }
 
     void Reset() {
@@ -424,6 +426,7 @@ struct ImPlot3DTicker {
 // Holds axis information
 struct ImPlot3DAxis {
     ImPlot3DAxisFlags Flags;
+    ImPlot3DAxisFlags PreviousFlags;
     ImPlot3DRange Range;
     ImPlot3DCond RangeCond;
     ImGuiTextBuffer Label;
@@ -440,7 +443,7 @@ struct ImPlot3DAxis {
 
     // Constructor
     ImPlot3DAxis() {
-        Flags = ImPlot3DAxisFlags_None;
+        PreviousFlags = Flags = ImPlot3DAxisFlags_None;
         // Range
         Range.Min = 0.0f;
         Range.Max = 1.0f;
@@ -510,6 +513,7 @@ struct ImPlot3DAxis {
 struct ImPlot3DPlot {
     ImGuiID ID;
     ImPlot3DFlags Flags;
+    ImPlot3DFlags PreviousFlags;
     ImGuiTextBuffer Title;
     bool JustCreated;
     // Bounding rectangles
@@ -540,7 +544,7 @@ struct ImPlot3DPlot {
     bool OpenContextThisFrame;
 
     ImPlot3DPlot() {
-        Flags = ImPlot3DFlags_None;
+        PreviousFlags = Flags = ImPlot3DFlags_None;
         JustCreated = true;
         Rotation = ImPlot3DQuat(0.0f, 0.0f, 0.0f, 1.0f);
         for (int i = 0; i < 3; i++)