Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Engine Support #54

Closed
ndmax opened this issue Sep 20, 2024 · 3 comments
Closed

Node Engine Support #54

ndmax opened this issue Sep 20, 2024 · 3 comments

Comments

@ndmax
Copy link

ndmax commented Sep 20, 2024

I have monoply-money deployed on my home network, and it literally puts Monopoly on the table for family game night. Thank you @brentvollebregt for this awesome project - the functionality for playing the game is really well executed.

Not really an issue or bug, but with the end of life for Node 16 LTS, are there any plans to bump current requirements to Node 20 (LTS)?

I tried just updating package.json to Node 22 / NPM 10 (which is just what was active on my system at the moment):

"engines": {
    "node": "22.x",
    "npm": "10.x"
  }

But got the following error on npm run build

Node.js v22.9.0
npm error Lifecycle script `build` failed with error:
npm error code 1
npm error path /home/.../monopoly-money/packages/client
npm error workspace [email protected]
npm error location /home/.../monopoly-money/packages/client
npm error command failed
npm error command sh -c react-scripts build
@brentvollebregt
Copy link
Owner

Thanks for the feedback, it's awesome to hear 😃

I hadn't planned to upgrade the supported node version but with support ending soon, that sounds like a good idea. It would also be a good opportunity to migrate from react-scripts to vite.

In the meantime, using the Dockerfile should still work (assuming docker is available). Using docker will mean you don't need to install node 16 on your machine.

@brentvollebregt
Copy link
Owner

Was no easy path, but we are running Node 22 now 🥳

@ndmax
Copy link
Author

ndmax commented Oct 23, 2024

Just updated - working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants