fix: removed uuidv4 dep and resolved umd duplicate code warnings

 - Removed uuidv4 as dependency (export mechanism broken since first used in Nov, 2019!)
 + Added small, fast built-in uuid function
 * Resolved duplicate dropped variable warnings for umd bundle

Author: Jon Rista

.gitignore

@@ -7,6 +7,7 @@
 
 # dependencies
 /node_modules
+/projects/ngrx-auto-entity/node_modules
 
 # IDEs and editors
 /.idea

CHANGELOG.md

@@ -1,3 +1,19 @@
+<a name="0.3.1"></a>
+
+# [0.3.1](https://github.com/briebug/ngrx-auto-entity/compare/0.3.0...0.3.1) Beta (2020-01-07)
+
+Bug fix release! We apologize for any inconvenience the v0.3.0 release may have caused. We introduced
+a correlation Id into our actions, and relied on `uuidv4` to handle their generation. Turned out, uuidv4
+just recently went through a breaking change, and the default import was removed. This caused problems,
+dependent upon which version of uuidv4 was used by the application using ngrx-ae.
+
+We have replaced uuidv4 with internal code. Fast, small uuid function acquired from the following gist:
+
+https://gist.github.com/LeverOne/1308368
+
+### Bug Fix
+- **[uuidv4](https://www.npmjs.com/package/uuidv4):** Removed in favor of small, fast built in function 
+
 <a name="0.3.0"></a>
 
 # [0.3.0](https://github.com/briebug/ngrx-auto-entity/compare/0.2.8...0.3.0) Beta (2019-11-26)

README.md

@@ -14,6 +14,13 @@ Automatic entities for [@ngrx](https://github.com/ngrx/platform)! Simplifying re
 enhance it's functionality, identify and eliminate bugs, optimize it's performance. If you
 find any errors in this documentation, or bugs within the library, please let us know!**
 
+**APOLOGIES: For those using NgRx Auto-Entity, we apologize for issues with the recent v0.3.0
+release! We used an npm module, uuidv4, and back in november our usage of it was working. It 
+appears as though that library was changed fairly significantly since then, with the default
+import removed. That lead to issues for some people, depending on the version of uuidv4 they 
+installed/had installed. We have dropped uuidv4 and are now using a small, fast built-in function
+instead in v0.3.1 and onward, which should resolve the issues. Again, we apologize for the inconvenience!**
+
 ## What is it?
 
 NgRX Auto-Entity aims to provide a seamless means of dealing with standard entity actions and

package-lock.json

@@ -14,6 +14,13 @@ Automatic entities for [@ngrx](https://github.com/ngrx/platform)! Simplifying re
 enhance it's functionality, identify and eliminate bugs, optimize it's performance. If you
 find any errors in this documentation, or bugs within the library, please let us know!**
 
+**APOLOGIES: For those using NgRx Auto-Entity, we apologize for issues with the recent v0.3.0
+release! We used an npm module, uuidv4, and back in november our usage of it was working. It 
+appears as though that library was changed fairly significantly since then, with the default
+import removed. That lead to issues for some people, depending on the version of uuidv4 they 
+installed/had installed. We have dropped uuidv4 and are now using a small, fast built-in function
+instead in v0.3.1 and onward, which should resolve the issues. Again, we apologize for the inconvenience!**
+
 ## What is it?
 
 NgRX Auto-Entity aims to provide a seamless means of dealing with standard entity actions and

projects/ngrx-auto-entity/README.md

@@ -1,5 +1,5 @@
 {
-  "version": "0.3.0",
+  "version": "0.3.1",
   "name": "@briebug/ngrx-auto-entity",
   "description": "Automatic Entity State and Facades for NgRx. Simplifying reactive state!",
   "keywords": [
@@ -24,7 +24,6 @@
     "@angular/core": "8.x",
     "@ngrx/effects": "8.x",
     "@ngrx/store": "8.x",
-    "rxjs": "6.x",
-    "uuidv4": ">=4.x <=6.x"
+    "rxjs": "6.x"
   }
 }

projects/ngrx-auto-entity/package.json

@@ -2,7 +2,6 @@ import { TestBed } from '@angular/core/testing';
 import { provideMockActions } from '@ngrx/effects/testing';
 import { hot } from 'jasmine-marbles';
 import { Observable } from 'rxjs';
-import uuid from 'uuidv4';
 import {
   Clear,
   Create,
@@ -103,6 +102,15 @@ const testError = {
 
 const criteria = { criteria: 'test' };
 
+const regex = {
+  v4: /^(?:[a-f0-9]{8}-[a-f0-9]{4}-4[a-f0-9]{3}-[a-f0-9]{4}-[a-f0-9]{12})|(?:0{8}-0{4}-0{4}-0{4}-0{12})$/u,
+  v5: /^(?:[a-f0-9]{8}-[a-f0-9]{4}-5[a-f0-9]{3}-[a-f0-9]{4}-[a-f0-9]{12})|(?:0{8}-0{4}-0{4}-0{4}-0{12})$/u
+};
+
+const isUuid = (value: string): boolean => {
+  return regex.v4.test(value) || regex.v5.test(value);
+};
+
 describe('NgRX Auto-Entity: Actions', () => {
   let actions: Observable<any>;
 
@@ -116,7 +124,7 @@ describe('NgRX Auto-Entity: Actions', () => {
     it('should construct EntityAction with correlationId initialized to a random uuid', () => {
       const action = new Load(TestEntity, 1);
 
-      expect(uuid.is(action.correlationId)).toEqual(true);
+      expect(isUuid(action.correlationId)).toEqual(true);
     });
   });
 

projects/ngrx-auto-entity/src/lib/actions.spec.ts

@@ -2,7 +2,6 @@ import { Actions } from '@ngrx/effects';
 import { Action } from '@ngrx/store';
 import { merge, Observable, OperatorFunction } from 'rxjs';
 import { filter } from 'rxjs/operators';
-import uuid from 'uuidv4';
 import { pascalCase } from '../util/case';
 import { checkKeyName } from './decorators';
 import { IPageInfo, IRangeInfo, Page, Range } from './models';
@@ -109,6 +108,13 @@ export interface IEntityAction extends Action, ICorrelatedAction {
   info: IEntityInfo;
 }
 
+// tslint:disable
+const uuid = (a?, b?) => {
+  for (b = a = ''; a++ < 36; b += a * 51 & 52 ? (a ^ 15 ? 8 ^ Math.random() * (a ^ 20 ? 16 : 4) : 4).toString(16) : '-') ;
+  return b;
+};
+// tslint:enable
+
 /**
  * Structure for all of this library's actions
  */

projects/ngrx-auto-entity/src/lib/actions.ts

@@ -25,12 +25,7 @@ export interface NgRxAutoEntityModuleConfig {
   ]
 })
 export class NgRxAutoEntityRootModuleWithEffects {
-  constructor(
-    private effectSources: EffectSources,
-    entityEffects: EntityEffects,
-    extraEffects: ExtraEffects,
-    injector: Injector
-  ) {
+  constructor(private effectSources: EffectSources, entityEffects: EntityEffects, extraEffects: ExtraEffects) {
     // NOTE: The following trick learned from @ngrx/data!
 
     // Warning: this alternative approach relies on an undocumented API
@@ -58,7 +53,7 @@ export class NgRxAutoEntityRootModuleWithEffects {
   ]
 })
 export class NgRxAutoEntityRootModuleNoEntityEffects {
-  constructor(private effectSources: EffectSources, extraEffects: ExtraEffects, injector: Injector) {
+  constructor(private effectSources: EffectSources, extraEffects: ExtraEffects) {
     // NOTE: The following trick learned from @ngrx/data!
 
     // Warning: this alternative approach relies on an undocumented API

projects/ngrx-auto-entity/src/lib/module.ts

@@ -71,15 +71,14 @@ export const handleError = <TModel, TErrorAction>(
   error: IEntityError<TModel>,
   errorAction: TErrorAction
 ): Observable<TErrorAction> => {
+  const serviceName = `${pascalCase(error.info.modelName)}Service`;
   if (error.err instanceof TypeError) {
-    const serviceName = `${pascalCase(error.info.modelName)}Service`;
     console.error(
       `[NGRX-AE] ! NgRxAutoEntityService Error: Unable to locate load method in the ${serviceName}`,
       '\nReason: ',
       error.err
     );
   } else if (error.info && error.message) {
-    const serviceName = `${pascalCase(error.info.modelName)}Service`;
     console.error(
       `[NGRX-AE] ! NgRxAutoEntityService Error: Unable to invoke required operations on the ${serviceName}`,
       '\nReason: ',