Skip to content

Commit 724220a

Browse files
authored
Link checking: update ignore rules for use with htmltest 0.16.0 (grpc#1034)
1 parent 3687d1c commit 724220a

File tree

3 files changed

+12
-30
lines changed

3 files changed

+12
-30
lines changed

Diff for: .htmltest.yml

+7-27
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,16 @@
11
DirectoryPath: public
22
IgnoreAltMissing: true
33
IgnoreDirectoryMissingTrailingSlash: true
4-
CheckDoctype: false # Sadly, this is false only because of `google*.html`
4+
CheckDoctype: false # Sadly, this is false only because of `static/google*.html`
55
IgnoreURLs:
6+
- ^(\.\./)?api/?$
7+
- ^/docs/(languages|platforms/android)/[-\w]+/(api|daily-builds)/$
8+
- ^/grpc/python/grpc\.html\?#grpc\.(Stream|Unary)+MultiCallable
69
- ^https?://localhost
7-
- http://bit\.ly/gRPC18survey # survey is closed and DNE
8-
- https://(www.)?envoyproxy.io # valid link but flakey (https://github.com/envoyproxy/envoyproxy.github.io/issues/193)
10+
- ^http://bit\.ly/gRPC18survey # survey is closed and DNE
11+
- ^https://(www\.)?envoyproxy.io$ # valid link but flakey (https://github.com/envoyproxy/envoyproxy.github.io/issues/193)
12+
- ^https://twitter.com/grpcio$ # valid and unlikely to change
913
IgnoreInternalURLs:
10-
- ../api
11-
- /docs/languages/cpp/api/
12-
- /docs/languages/csharp/api/
13-
- /docs/languages/csharp/daily-builds/
14-
- /docs/languages/dart/api/
15-
- /docs/languages/go/api/
16-
- /docs/languages/java/api/
17-
- /docs/languages/kotlin/api
18-
- /docs/languages/kotlin/api/
19-
- /docs/languages/node/api/
20-
- /docs/languages/objective-c/api/
21-
- /docs/languages/php/api/
22-
- /docs/languages/php/daily-builds/
23-
- /docs/languages/python/api/
24-
- /docs/languages/python/daily-builds/
25-
- /docs/languages/ruby/api/
26-
- /docs/languages/ruby/daily-builds/
27-
- /docs/platforms/android/java/api/
28-
- /docs/platforms/android/kotlin/api/
2914
- /grpc/cpp/classgrpc_1_1_completion_queue.html
3015
- /grpc/python/_modules/grpc.html#Server
31-
- /grpc/python/grpc.html?#grpc.StreamStreamMultiCallable
32-
- /grpc/python/grpc.html?#grpc.StreamUnaryMultiCallable
33-
- /grpc/python/grpc.html?#grpc.UnaryStreamMultiCallable
34-
- /grpc/python/grpc.html?#grpc.UnaryUnaryMultiCallable
35-
- api/
3616
- daily-builds

Diff for: Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,17 @@ HTMLTEST?=htmltest # Specify as make arg if different
22
HTMLTEST_ARGS?=--skip-external
33
HTMLTEST_DIR=tmp
44

5-
# Use $(HTMLTEST) in PATH, if available; otherwise, we'll get a copy
5+
# Use $(HTMLTEST) in PATH, if available; otherwise, get a copy
66
ifeq (, $(shell which $(HTMLTEST)))
77
override HTMLTEST=$(HTMLTEST_DIR)/bin/htmltest
88
ifeq (, $(shell which $(HTMLTEST)))
99
GET_LINK_CHECKER_IF_NEEDED=get-link-checker
1010
endif
1111
endif
1212

13-
check-links: $(GET_LINK_CHECKER_IF_NEEDED)
13+
check-links: $(GET_LINK_CHECKER_IF_NEEDED) htmltest
14+
15+
htmltest:
1416
$(HTMLTEST) $(HTMLTEST_ARGS)
1517

1618
get-link-checker:

Diff for: content/en/blog/kotlin-meet-grpc.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ For more information, see the following [Kotlin pages][]:
2828

2929
- [Quick start](/docs/languages/kotlin/quickstart/)
3030
- [Basics tutorial](/docs/languages/kotlin/basics/)
31-
- [API reference](/docs/languages/kotlin/api)
31+
- [API reference](/docs/languages/kotlin/api/)
3232

3333
[blog]: https://cloud.google.com/blog/products/application-development/use-grpc-with-kotlin
3434
[Cloud Run]: https://cloud.run

0 commit comments

Comments
 (0)