New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chaincfg.Params.PubKeyHashAddrID one byte prefix #2231

Open

bambinorest1 opened this issue Aug 13, 2024 · 0 comments

bambinorest1 commented Aug 13, 2024

Maybe it would be better if such fields like PubKeyHashAddrID or ScriptHashAddrID of the structure were a slice of bytes. Because some bitcoin forks have prefixes larger than one byte. For example zcash:
https://github.com/zcash/zcash/blob/60b971f8af47d8f4032789078c0c9c846bbf6710/src/chainparams.cpp#L152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment