feat: implement os_invalid_raw_handle function for consistent invalid handle representation

Author: lum1n0us

core/iwasm/aot/aot_loader.c

@@ -4121,13 +4121,9 @@ create_module(char *name, char *error_buf, uint32 error_buf_size)
 #endif
 
 #if WASM_ENABLE_LIBC_WASI != 0
-    /*
-     * learned from all implementations of `os_get_invalid_handle()`
-     * that invalid handles across all platforms are represented by -1.
-     */
-    module->wasi_args.stdio[0] = -1;
-    module->wasi_args.stdio[1] = -1;
-    module->wasi_args.stdio[2] = -1;
+    module->wasi_args.stdio[0] = os_invalid_raw_handle();
+    module->wasi_args.stdio[1] = os_invalid_raw_handle();
+    module->wasi_args.stdio[2] = os_invalid_raw_handle();
 #endif
 
     return module;

core/iwasm/interpreter/wasm_loader.c

@@ -6369,13 +6369,9 @@ create_module(char *name, char *error_buf, uint32 error_buf_size)
 #endif
 
 #if WASM_ENABLE_LIBC_WASI != 0
-    /*
-     * learned from all implementations of `os_get_invalid_handle()`
-     * that invalid handles across all platforms are represented by -1.
-     */
-    module->wasi_args.stdio[0] = -1;
-    module->wasi_args.stdio[1] = -1;
-    module->wasi_args.stdio[2] = -1;
+    module->wasi_args.stdio[0] = os_invalid_raw_handle();
+    module->wasi_args.stdio[1] = os_invalid_raw_handle();
+    module->wasi_args.stdio[2] = os_invalid_raw_handle();
 #endif
 
     (void)ret;

core/iwasm/interpreter/wasm_mini_loader.c

@@ -3122,6 +3122,12 @@ create_module(char *name, char *error_buf, uint32 error_buf_size)
     }
 #endif
 
+#if WASM_ENABLE_LIBC_WASI != 0
+    module->wasi_args.stdio[0] = os_invalid_raw_handle();
+    module->wasi_args.stdio[1] = os_invalid_raw_handle();
+    module->wasi_args.stdio[2] = os_invalid_raw_handle();
+#endif
+
     (void)ret;
     return module;
 }

core/shared/platform/alios/alios_platform.c

@@ -79,3 +79,9 @@ os_dcache_flush()
 void
 os_icache_flush(void *start, size_t len)
 {}
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}

core/shared/platform/common/posix/posix_file.c

@@ -1032,4 +1032,10 @@ char *
 os_realpath(const char *path, char *resolved_path)
 {
     return realpath(path, resolved_path);
-}
+}
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}

core/shared/platform/esp-idf/espidf_file.c

@@ -1032,4 +1032,10 @@ char *
 os_realpath(const char *path, char *resolved_path)
 {
     return realpath(path, resolved_path);
-}
+}
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}

core/shared/platform/include/platform_api_extension.h

@@ -1607,6 +1607,15 @@ os_is_dir_stream_valid(os_dir_stream *dir_stream);
 os_file_handle
 os_get_invalid_handle(void);
 
+/**
+ * Returns an invalid raw file handle that is guaranteed to cause failure when
+ * called with any filesystem operation.
+ *
+ * @return the invalid raw file handle
+ */
+os_raw_file_handle
+os_invalid_raw_handle(void);
+
 /**
  * Checks whether the given file handle is valid. An invalid handle is
  * guaranteed to cause failure when called with any filesystem operation.

core/shared/platform/linux-sgx/sgx_file.c

@@ -1114,4 +1114,10 @@ get_errno(void)
     return ret;
 }
 
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}
+
 #endif

core/shared/platform/riot/riot_platform.c

@@ -95,3 +95,9 @@ os_dcache_flush(void)
 void
 os_icache_flush(void *start, size_t len)
 {}
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}

core/shared/platform/rt-thread/rtt_file.c

@@ -192,3 +192,9 @@ posix_fallocate(int __fd, off_t __offset, off_t __length)
     errno = ENOSYS;
     return -1;
 }
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}

core/shared/platform/windows/win_file.c

@@ -1810,3 +1810,9 @@ os_realpath(const char *path, char *resolved_path)
 
     return resolved_path;
 }
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return INVALID_HANDLE_VALUE;
+}

core/shared/platform/zephyr/zephyr_platform.c

@@ -255,3 +255,9 @@ set_exec_mem_alloc_func(exec_mem_alloc_func_t alloc_func,
     exec_mem_alloc_func = alloc_func;
     exec_mem_free_func = free_func;
 }
+
+os_raw_file_handle
+os_invalid_raw_handle(void)
+{
+    return -1;
+}