Review feedback: error on registering profiling metadata when debug is enabled.

Author: cfallin

crates/wasmtime/src/runtime/instantiate.rs

@@ -3,7 +3,7 @@
 //! `CompiledModule` to allow compiling and instantiating to be done as separate
 //! steps.
 
-use crate::code::EngineCode;
+use crate::{code::EngineCode, Engine};
 use crate::prelude::*;
 use crate::profiling_agent::ProfilingAgent;
 use crate::runtime::vm::CompiledModuleId;
@@ -47,6 +47,7 @@ impl CompiledModule {
     /// The `profiler` argument here is used to inform JIT profiling runtimes
     /// about new code that is loaded.
     pub fn from_artifacts(
+        engine: &Engine,
         engine_code: Arc<EngineCode>,
         info: CompiledModuleInfo,
         index: Arc<CompiledFunctionsTable>,
@@ -60,16 +61,20 @@ impl CompiledModule {
             index,
             func_names: info.func_names,
         };
-        ret.register_profiling(profiler)?;
+        ret.register_profiling(engine, profiler)?;
 
         Ok(ret)
     }
 
-    fn register_profiling(&mut self, profiler: &dyn ProfilingAgent) -> Result<()> {
+    fn register_profiling(&mut self, engine: &Engine, profiler: &dyn ProfilingAgent) -> Result<()> {
         // TODO-Bug?: "code_memory" is not exclusive for this module in the case of components,
         // so we may be registering the same code range multiple times here.
-        //
-        // TODO: register for each StoreCode.
+
+        if engine.tunables().debug_guest {
+            // TODO(#12105): support this case.
+            anyhow::bail!("Cannot register profiling when guest debugging is enabled");
+        }
+
         profiler.register_module(self.engine_code.image(), &|addr| {
             let idx = self.func_by_text_offset(addr)?;
             let idx = self.module.func_index(idx);

crates/wasmtime/src/runtime/module.rs

@@ -532,7 +532,8 @@ impl Module {
         index: Arc<CompiledFunctionsTable>,
         serializable: bool,
     ) -> Result<Self> {
-        let module = CompiledModule::from_artifacts(code.clone(), info, index, engine.profiler())?;
+        let module =
+            CompiledModule::from_artifacts(engine, code.clone(), info, index, engine.profiler())?;
 
         // Validate the module can be used with the current instance allocator.
         let offsets = VMOffsets::new(HostPtr, module.module());