Remove the unnecessary "longestElement" variable in the Trie creation/traversing mechanism

Author: bytexenon

src/Helpers/Helpers.lua

@@ -54,16 +54,10 @@ end
 --- Creates a trie from the given operators, it's used to support 2+ character (potentional) operators.
 -- @param <Table> table The operators to create the trie from.
 -- @return <Table> trieTable The trie table.
--- @return <Number> longestElement The length of the longest operator.
 function Helpers.makeTrie(table)
   local trieTable = {}
-  local longestElement = 0
 
   for _, op in ipairs(table) do
-    if #op > longestElement then
-      longestElement = #op
-    end
-
     local node = trieTable
     for index = 1, #op do
       local character = op:sub(index, index)
@@ -72,7 +66,7 @@ function Helpers.makeTrie(table)
     end
     node.value = op
   end
-  return trieTable, longestElement
+  return trieTable
 end
 
 return Helpers

src/Lexer/Lexer.lua

@@ -219,20 +219,21 @@ end
 -- @return <Table> operatorToken The next operator token.
 function LexerMethods:consumeOperator()
   local node            = self.operatorsTrie
-  local longestOperator = self.longestOperator
   local charStream      = self.charStream
   local curCharPos      = self.curCharPos
   local operator
 
   -- Trie walker
-  for index = 0, longestOperator - 1 do
+  local index = 0
+  while true do
     -- Use raw charStream instead of methods for optimization
     local character = charStream[curCharPos + index]
     node = node[character] -- Advance to the deeper node
     if not node then break end
     if node.value then
       operator = node.value
     end
+    index = index + 1
   end
   if operator then
     self:consume(#operator - 1)
@@ -299,7 +300,7 @@ function LexerMethods:resetToInitialState(charStream, operators)
   self.curCharPos = 1
 
   self.operators = operators or DEFAULT_OPERATORS
-  self.operatorsTrie, self.longestOperator = makeTrie(self.operators)
+  self.operatorsTrie = makeTrie(self.operators)
 end
 
 --- Runs the lexer.
@@ -331,11 +332,10 @@ function Lexer:new(expression, operators, charPos)
   end
   if operators then
     LexerInstance.operators = operators
-    LexerInstance.operatorsTrie, LexerInstance.longestOperator = makeTrie(operators)
+    LexerInstance.operatorsTrie = makeTrie(operators)
   else
     LexerInstance.operators = DEFAULT_OPERATORS
     LexerInstance.operatorsTrie = DEFAULT_OPERATORS_TRIE
-    LexerInstance.longestOperator = DEFAULT_LONGEST_OPERATOR
   end
 
   local function inheritModule(moduleName, moduleTable)