Resolve coverity defects concerning potential dead code and uncaught exceptions

Author: nigels-com

tinyformat.h

@@ -318,8 +318,8 @@ inline void formatValue(std::ostream& out, const char* /*fmtBegin*/,
     // void* respectively and format that instead of the value itself.  For the
     // %p conversion it's important to avoid dereferencing the pointer, which
     // could otherwise lead to a crash when printing a dangling (const char*).
-    bool canConvertToChar = detail::is_convertible<T,char>::value;
-    bool canConvertToVoidPtr = detail::is_convertible<T, const void*>::value;
+    const bool canConvertToChar = detail::is_convertible<T,char>::value;
+    const bool canConvertToVoidPtr = detail::is_convertible<T, const void*>::value;
     if(canConvertToChar && *(fmtEnd-1) == 'c')
         detail::formatValueAsType<T, char>::invoke(out, value);
     else if(canConvertToVoidPtr && *(fmtEnd-1) == 'p')

tinyformat_test.cpp

@@ -266,5 +266,13 @@ int unitTests()
 
 int main()
 {
-    return unitTests();
+    try
+    {
+        return unitTests();
+    }
+    catch (std::runtime_error & e)
+    {
+        std::cout << "Failure due to uncaught exception: " << e.what() << std::endl;
+        return EXIT_FAILURE;
+    }
 }