[domain-deletion]Add domain delete CLI command (#6908)

* [domain-deletion]Add domain delete CLI command

* Update tests & make security token required flag

* Add test case for deletion cancelled

* Update tests

Author: gazi-yestemirova

tools/cli/admin.go

@@ -403,6 +403,17 @@ func newAdminDomainCommands() []*cli.Command {
 				})
 			},
 		},
+		{
+			Name:    "delete",
+			Aliases: []string{"del"},
+			Usage:   "Delete existing workflow domain",
+			Flags:   adminDeleteDomainFlags,
+			Action: func(c *cli.Context) error {
+				return withDomainClient(c, true, func(dc *domainCLIImpl) error {
+					return dc.DeleteDomain(c)
+				})
+			},
+		},
 		{
 			Name:    "deprecate",
 			Aliases: []string{"dep"},

tools/cli/app_test.go

@@ -200,6 +200,73 @@ var describeDomainResponseServer = &types.DescribeDomainResponse{
 	},
 }
 
+// This is used to mock the domain deletion confirmation
+func (s *cliAppSuite) mockStdinInput(input string) func() {
+	oldStdin := os.Stdin
+	r, w, err := os.Pipe()
+	s.Require().NoError(err)
+	os.Stdin = r
+
+	go func() {
+		_, wrErr := w.Write([]byte(input + "\n"))
+		s.Require().NoError(wrErr)
+		err = w.Close()
+		s.Require().NoError(err)
+	}()
+
+	return func() {
+		os.Stdin = oldStdin
+		r.Close()
+	}
+}
+
+func (s *cliAppSuite) TestDomainDelete() {
+	resp := describeDomainResponseServer
+	s.serverFrontendClient.EXPECT().DescribeDomain(gomock.Any(), gomock.Any()).Return(resp, nil)
+	s.serverFrontendClient.EXPECT().DeleteDomain(gomock.Any(), gomock.Any()).Return(nil)
+
+	defer s.mockStdinInput("Yes")()
+	err := s.app.Run([]string{"", "--do", domainName, "domain", "delete", "--st", "test-token"})
+	s.Nil(err)
+}
+
+func (s *cliAppSuite) TestDomainDelete_DomainNotExist() {
+	s.serverFrontendClient.EXPECT().DescribeDomain(gomock.Any(), gomock.Any()).Return(nil, &types.EntityNotExistsError{})
+	s.Error(s.app.Run([]string{"", "--do", domainName, "domain", "delete", "--st", "test-token"}))
+}
+
+func (s *cliAppSuite) TestDomainDelete_Failed() {
+	resp := describeDomainResponseServer
+	s.serverFrontendClient.EXPECT().DescribeDomain(gomock.Any(), gomock.Any()).Return(resp, nil)
+	s.serverFrontendClient.EXPECT().DeleteDomain(gomock.Any(), gomock.Any()).Return(&types.BadRequestError{"mock error"})
+
+	defer s.mockStdinInput("Yes")()
+	s.Error(s.app.Run([]string{"", "--do", domainName, "domain", "delete", "--st", "test-token"}))
+}
+
+func (s *cliAppSuite) TestDomainDelete_Cancelled() {
+	resp := describeDomainResponseServer
+	s.serverFrontendClient.EXPECT().DescribeDomain(gomock.Any(), gomock.Any()).Return(resp, nil)
+
+	oldStdout := os.Stdout
+	r, w, _ := os.Pipe()
+	os.Stdout = w
+
+	defer func() {
+		os.Stdout = oldStdout
+	}()
+
+	defer s.mockStdinInput("No")()
+	err := s.app.Run([]string{"", "--do", domainName, "domain", "delete", "--st", "test-token"})
+	s.Nil(err)
+
+	w.Close()
+	var stdoutBuf bytes.Buffer
+	io.Copy(&stdoutBuf, r)
+
+	s.Contains(stdoutBuf.String(), "Domain deletion cancelled")
+}
+
 func (s *cliAppSuite) TestDomainDeprecate() {
 	s.serverFrontendClient.EXPECT().StartWorkflowExecution(gomock.Any(), gomock.Any()).Return(&types.StartWorkflowExecutionResponse{
 		RunID: "run-id-example",

tools/cli/domain.go

@@ -87,6 +87,21 @@ func newDomainCommands() []*cli.Command {
 				})
 			},
 		},
+		{
+			Name:    "delete",
+			Aliases: []string{"del"},
+			Usage:   "Delete existing workflow domain",
+			Flags:   deleteDomainFlags,
+			Action: func(c *cli.Context) error {
+				err := checkNoAdditionalArgsPassed(c)
+				if err != nil {
+					return err
+				}
+				return withDomainClient(c, false, func(dc *domainCLIImpl) error {
+					return dc.DeleteDomain(c)
+				})
+			},
+		},
 		{
 			Name:    "deprecate",
 			Aliases: []string{"dep"},

tools/cli/domain_commands.go

@@ -21,10 +21,12 @@
 package cli
 
 import (
+	"bufio"
 	"context"
 	"encoding/json"
 	"errors"
 	"fmt"
+	"os"
 	"strconv"
 	"strings"
 	"time"
@@ -304,6 +306,70 @@ func (d *domainCLIImpl) UpdateDomain(c *cli.Context) error {
 	return nil
 }
 
+func (d *domainCLIImpl) DeleteDomain(c *cli.Context) error {
+	domainName, err := getRequiredOption(c, FlagDomain)
+	if err != nil {
+		return commoncli.Problem("Required flag not found: ", err)
+	}
+	securityToken, err := getRequiredOption(c, FlagSecurityToken)
+	if err != nil {
+		return commoncli.Problem("Required flag not provided: ", err)
+	}
+
+	ctx, cancel, err := newContext(c)
+	defer cancel()
+	if err != nil {
+		return commoncli.Problem("Error in creating context: ", err)
+	}
+
+	// First describe the domain to show its details
+	describeRequest := &types.DescribeDomainRequest{
+		Name: &domainName,
+	}
+	resp, err := d.describeDomain(ctx, describeRequest)
+	if err != nil {
+		if _, ok := err.(*types.EntityNotExistsError); !ok {
+			return commoncli.Problem("Operation DescribeDomain failed.", err)
+		}
+		return commoncli.Problem(fmt.Sprintf("Domain %s does not exist.", domainName), err)
+	}
+
+	if err := Render(c, newDomainRow(resp), RenderOptions{
+		DefaultTemplate: templateDomain,
+		Color:           true,
+		Border:          true,
+		PrintDateTime:   true,
+	}); err != nil {
+		return fmt.Errorf("failed to render domain details: %w", err)
+	}
+
+	fmt.Print("Do you want to delete this domain? \n")
+	reader := bufio.NewReader(os.Stdin)
+	for {
+		fmt.Print("Please confirm[Yes/No]:")
+		text, err := reader.ReadString('\n')
+		if err != nil {
+			return commoncli.Problem("Failed to get confirmation for domain deletion", err)
+		}
+		if strings.EqualFold(strings.TrimSpace(text), "yes") {
+			break
+		} else {
+			fmt.Println("Domain deletion cancelled")
+			return nil
+		}
+	}
+
+	err = d.deleteDomain(ctx, &types.DeleteDomainRequest{
+		Name:          domainName,
+		SecurityToken: securityToken,
+	})
+	if err != nil {
+		return commoncli.Problem("Operation Delete domain failed.", err)
+	}
+	fmt.Printf("Domain %s successfully deleted.\n", domainName)
+	return nil
+}
+
 func (d *domainCLIImpl) DeprecateDomain(c *cli.Context) error {
 	domainName, err := getRequiredOption(c, FlagDomain)
 	if err != nil {
@@ -753,6 +819,18 @@ func (d *domainCLIImpl) updateDomain(
 	return d.domainHandler.UpdateDomain(ctx, request)
 }
 
+func (d *domainCLIImpl) deleteDomain(
+	ctx context.Context,
+	request *types.DeleteDomainRequest,
+) error {
+
+	if d.frontendClient != nil {
+		return d.frontendClient.DeleteDomain(ctx, request)
+	}
+
+	return d.domainHandler.DeleteDomain(ctx, request)
+}
+
 func (d *domainCLIImpl) describeDomain(
 	ctx context.Context,
 	request *types.DescribeDomainRequest,

tools/cli/domain_utils.go

@@ -197,6 +197,14 @@ var (
 		},
 	}
 
+	deleteDomainFlags = []cli.Flag{
+		&cli.StringFlag{
+			Name:    FlagSecurityToken,
+			Aliases: []string{"st"},
+			Usage:   "Optional token for security check",
+		},
+	}
+
 	deprecateDomainFlags = []cli.Flag{
 		&cli.StringFlag{
 			Name:    FlagSecurityToken,
@@ -258,6 +266,11 @@ var (
 		adminDomainCommonFlags...,
 	)
 
+	adminDeleteDomainFlags = append(
+		deleteDomainFlags,
+		adminDomainCommonFlags...,
+	)
+
 	adminDeprecateDomainFlags = append(
 		deprecateDomainFlags,
 		adminDomainCommonFlags...,