Skip to content

Commit 891ac2a

Browse files
committed
refactor: create dedicated file for generating logging config
1 parent 006de31 commit 891ac2a

File tree

2 files changed

+30
-20
lines changed

2 files changed

+30
-20
lines changed

benefits/logging.py

+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
def get_config(level):
2+
return {
3+
"version": 1,
4+
"disable_existing_loggers": False,
5+
"formatters": {
6+
"default": {
7+
"format": "[{asctime}] {levelname} {name}:{lineno} {message}",
8+
"datefmt": "%d/%b/%Y %H:%M:%S",
9+
"style": "{",
10+
},
11+
},
12+
"handlers": {
13+
"default": {
14+
"class": "logging.StreamHandler",
15+
"formatter": "default",
16+
},
17+
},
18+
"root": {
19+
"handlers": ["default"],
20+
"level": level,
21+
},
22+
"loggers": {
23+
"django": {
24+
"handlers": ["default"],
25+
"propagate": False,
26+
},
27+
},
28+
}

benefits/settings.py

+2-20
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
Django settings for benefits project.
33
"""
44
import os
5+
import benefits.logging
56

67

78
def _filter_empty(ls):
@@ -192,27 +193,8 @@ def _filter_empty(ls):
192193
STATIC_ROOT = os.path.join(BASE_DIR, "static")
193194

194195
# Logging configuration
195-
196196
LOG_LEVEL = os.environ.get("DJANGO_LOG_LEVEL", "DEBUG" if DEBUG else "WARNING")
197-
LOGGING = {
198-
"version": 1,
199-
"disable_existing_loggers": False,
200-
"formatters": {
201-
"default": {
202-
"format": "[{asctime}] {levelname} {name}:{lineno} {message}",
203-
"datefmt": "%d/%b/%Y %H:%M:%S",
204-
"style": "{",
205-
},
206-
},
207-
"handlers": {
208-
"default": {"class": "logging.StreamHandler", "formatter": "default"},
209-
},
210-
"root": {
211-
"handlers": ["default"],
212-
"level": LOG_LEVEL,
213-
},
214-
"loggers": {"django": {"handlers": ["default"], "propagate": False}},
215-
}
197+
LOGGING = benefits.logging.get_config(LOG_LEVEL)
216198

217199
# Analytics configuration
218200

0 commit comments

Comments
 (0)