Skip to content

Commit c67a5b1

Browse files
committed
docs(deployment): update with new GitHub Actions info
remove outdated webhook references
1 parent bdde33b commit c67a5b1

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

docs/deployment/infrastructure.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -180,11 +180,10 @@ Use the following shorthand for conveying the Resource Type as part of the Resou
180180

181181
## Azure environment setup
182182

183-
The following steps are required to set up the environment, with linked issues to automate them:
183+
The following steps are required to set up the environment:
184184

185185
- `terraform apply`
186-
- Set up Slack notifications by [creating a Slack email](https://slack.com/help/articles/206819278-Send-emails-to-Slack) for the [#benefits-notify](https://cal-itp.slack.com/archives/C022HHSEE3F) channel, then [setting it as a Secret in the Key Vault](https://learn.microsoft.com/en-us/azure/key-vault/secrets/quick-create-portal#add-a-secret-to-key-vault) named `slack-benefits-notify-email`
186+
- Set up Slack notifications by [creating a Slack email](https://slack.com/help/articles/206819278-Send-emails-to-Slack) for the [#notify-benefits](https://cal-itp.slack.com/archives/C022HHSEE3F) channel, then [setting it as a Secret in the Key Vault](https://learn.microsoft.com/en-us/azure/key-vault/secrets/quick-create-portal#add-a-secret-to-key-vault) named `slack-benefits-notify-email`
187187
- Set required [App Service configuration](../configuration/environment-variables.md) and [configuration](../configuration/data.md) by setting values in Key Vault (the mapping is defined in [app_service.tf](https://github.com/cal-itp/benefits/blob/dev/terraform/app_service.tf))
188-
- [Set up webhook from GitHub](https://github.com/cal-itp/benefits/settings/hooks) to [App Service Deployment Center](https://learn.microsoft.com/en-us/azure/app-service/deploy-ci-cd-custom-container?tabs=acr&pivots=container-linux) for the `Packages` event
189188

190189
This is not a complete step-by-step guide; more a list of things to remember. This may be useful as part of [incident response](https://docs.google.com/document/d/1qtev8qItPiTB4Tp9FQ87XsLtWZ4HlNXqoe9vF2VuGcY/edit#).

docs/deployment/workflows.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,15 @@ Using the `github.actor` and built-in `GITHUB_TOKEN` secret
2323

2424
### 3. Build and push image to GitHub Container Registry (GHCR)
2525

26-
Build the root [`Dockerfile`][dockerfile], tagging with both the branch name (e.g. `dev`) and the SHA from the HEAD commit.
26+
Build the root [`Dockerfile`][dockerfile], tagging with the SHA from the HEAD commit.
2727

2828
Push this image:tag into [GHCR][ghcr].
2929

3030
### 4. App Service deploy
3131

32-
Each Azure App Service instance is configured to [listen to a webhook from GitHub, then deploy the image][webhook].
32+
Push the new image:tag to the Azure App Service instance.
3333

3434
[deploy]: https://github.com/cal-itp/benefits/blob/dev/.github/workflows/deploy.yml
3535
[dockerfile]: https://github.com/cal-itp/benefits/blob/dev/Dockerfile
3636
[ghcr]: https://github.com/features/packages
3737
[gh-actions-trigger]: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
38-
[webhook]: https://docs.microsoft.com/en-us/azure/app-service/deploy-ci-cd-custom-container

0 commit comments

Comments
 (0)