Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth refactor: create hooks implementation #2723

Open
4 tasks
thekaveman opened this issue Mar 7, 2025 · 0 comments
Open
4 tasks

OAuth refactor: create hooks implementation #2723

thekaveman opened this issue Mar 7, 2025 · 0 comments
Labels
analytics App event tracking, instrumentation, logging: Metabase, Amplitude back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc.

Comments

@thekaveman
Copy link
Member

Currently

Refactor

  • DefaultHooks provides definitions to plug into specific points in the integration with IdG
  • cdt_identity implements the views and redirects necessary for this integration, we won't need these in benefits anymore
  • benefits can provide a custom hooks implementation

Acceptance criteria

  • Define a custom hooks class e.g. benefits.oauth.hooks.OAuthHooks inheriting from cdt_identity.hooks.DefaultHooks
  • All calls to benefits.oauth.analytics functions happen within the corresponding custom hooks classmethod(s)
  • All calls to sentry_sdk.capture_exception() happen within the corresponding custom hooks classmethod(s)
  • All overridden classmethods call their corresponding DefaultHooks classmethod to start
@thekaveman thekaveman added analytics App event tracking, instrumentation, logging: Metabase, Amplitude back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc. labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics App event tracking, instrumentation, logging: Metabase, Amplitude back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc.
Projects
Status: Todo
Development

No branches or pull requests

1 participant