Typescript config conflict 'noEmit' and 'emitDeclarationOnly'

[mskorenkyi]

I receive an error (see below) when building my project with bob build.

tsconfig.json - error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

This error happens because my tsconfig.json file extends with the config from the @react-native/typescript-config package. In this package, noEmit is set as true.
So, it conflicts with --emitDeclarationOnly option passed in the targets /typescript.js file for tsc command.

my tsconfig.json file

{
  "extends": "@react-native/typescript-config/tsconfig.json",
  "compilerOptions": {
    "baseUrl": ".",
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "forceConsistentCasingInFileNames": true,
    "lib": ["esnext", "dom"],
    "module": "esnext",
    "noFallthroughCasesInSwitch": true,
    "noImplicitReturns": true,
    "noImplicitUseStrict": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": true,
    "target": "esnext"
  }
}

I know that I can copy code from the @react-native/typescript-config/tsconfig.json and paste it to my tsconfig.json, but this is bad solution. Because, in this case I would need to track changes in the @react-native/typescript-config/tsconfig.json and manually copy-paste them.

As a solution, builder bob can check if option noEmit is set in the config file, and then don't pass --emitDeclarationOnly option.

Any suggestion on how to solve the problem?

[atlj]

Hey, you should be able to easily override the noEmit option in your tsconfig.json file without changing React Native's config.

{
  "extends": "@react-native/typescript-config/tsconfig.json",
  "compilerOptions": {
    "baseUrl": ".",
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "forceConsistentCasingInFileNames": true,
    "lib": ["esnext", "dom"],
    "module": "esnext",
    "noFallthroughCasesInSwitch": true,
+   "noEmit": false,
    "noImplicitReturns": true,
    "noImplicitUseStrict": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": true,
    "target": "esnext"
  }
}

You can also use tsconfig.build.json file to set this setting. tsconfig.build.json is used only when you build the library using react-native-builder-bob.

As a solution, builder bob can check if option noEmit is set in the config file, and then don't pass --emitDeclarationOnly option.

When --noEmit is passed to tsc, it doesn't generate the .d.ts files and it means your builds won't include type information (besides the source code). So builder bob needs this option to be false to be able to work properly.

[mskorenkyi]

This fix helped me. Thanks!

[nsmet]

I'm experiencing the same issue. Tried @atlj's suggestion, but no luck. Any idea how to bypass this?

tsconfig.build.json

    "extends": "./tsconfig",
    "compilerOptions": {
        "baseUrl": ".",
        "allowUnreachableCode": false,
        "allowUnusedLabels": false,
        "forceConsistentCasingInFileNames": true,
        "lib": ["esnext", "dom"],
        "module": "esnext",
        "noFallthroughCasesInSwitch": true,
        "noEmit": false,
        "noImplicitReturns": true,
        "noImplicitUseStrict": false,
        "noStrictGenericChecks": false,
        "noUnusedLocals": true,
        "target": "esnext"
    }
}

tsconfig.json

    "extends": "@tsconfig/react-native/tsconfig.json",
    "compilerOptions": {
        "types": ["react-native", "node"],
        "typeRoots": ["@types", "./node_modules/@types"],
        "baseUrl": ".",
        "rootDir": ".",
        "paths": {
            "@qualli/qualli-rn-sdk": ["./src/index"]
        }
    },
    "include": ["src/"],
    "exclude": [
        "node_modules",
        "babel.config.js",
        "metro.config.js",
        "jest.config.js"
    ]
}

package.json

    "name": "@qualli/qualli-rn-sdk",
    "version": "1.0.0",
    "description": "Qualli React Native SDK - Product Research on auto-pilot",
    "main": "lib/commonjs/index",
    "module": "lib/module/index",
    "types": "lib/typescript/src/index.d.ts",
    "react-native": "src/index",
    "source": "src/index",
    "files": [
        "src",
        "lib",
        "!**/__tests__",
        "!**/__fixtures__",
        "!**/__mocks__",
        "android",
        "ios",
        "cpp",
        "*.podspec",
        "!ios/build",
        "!android/build",
        "!android/gradle",
        "!android/gradlew",
        "!android/gradlew.bat",
        "!android/local.properties",
        "!**/.*"
    ],
    "scripts": {
        "example": "yarn workspace qualli-rn-sdk-example",
        "typecheck": "tsc --noEmit",
        "lint": "eslint \"src/**/*.{js,ts,tsx}\"",
        "lint:fix": "eslint \"src/**/*.{js,ts,tsx}\" --fix",
        "clean": "del-cli lib",
        "prepare": "bob build",
        "release": "release-it"
    },
    "keywords": [
        "react-native",
        "ios",
        "android"
    ],
    "repository": "https://github.com/Qualli-Research-Platform/qualli-rn-sdk.git",
    "author": "Nick Smet <[email protected]> (https://usequalli.com)",
    "license": "MIT",
    "bugs": {
        "url": "https://github.com/Qualli-Research-Platform/qualli-rn-sdk.git/issues"
    },
    "homepage": "https://github.com/Qualli-Research-Platform/qualli-rn-sdk.git#readme",
    "publishConfig": {
        "registry": "https://registry.npmjs.org/"
    },
    "devDependencies": {
        "@react-native-async-storage/async-storage": "^1.19.3",
        "@react-native/eslint-config": "^0.72.2",
        "@tsconfig/react-native": "^3.0.2",
        "@types/node": "^20.8.7",
        "@types/react-native": "0.70.0",
        "del-cli": "^5.0.0",
        "eslint": "^8.51.0",
        "prettier": "^2.4.1",
        "react": "18.2.0",
        "react-native": "0.72.5",
        "react-native-builder-bob": "^0.23.1",
        "react-native-device-info": "^10.11.0",
        "release-it": "^15.0.0",
        "typescript": "^5.1.0"
    },
    "resolutions": {
        "@types/react": "17.0.21"
    },
    "peerDependencies": {
        "react": "*",
        "react-native": "*"
    },
    "workspaces": [
        "example"
    ],
    "packageManager": "[email protected]",
    "engines": {
        "node": ">= 18.0.0"
    },
    "commitlint": {
        "extends": [
            "@commitlint/config-conventional"
        ]
    },
    "release-it": {
        "git": {
            "commitMessage": "chore: release ${version}",
            "tagName": "v${version}"
        },
        "npm": {
            "publish": true
        },
        "github": {
            "release": true
        },
        "plugins": {
            "@release-it/conventional-changelog": {
                "preset": "angular"
            }
        }
    },
    "eslintIgnore": [
        "node_modules/",
        "lib/"
    ],
    "react-native-builder-bob": {
        "source": "src",
        "output": "lib",
        "targets": [
            "commonjs",
            "module",
            "typescript"
        ]
    }
}

[atlj]

Hey, are you getting the exact same error message or a different one?

[nsmet]

I'm getting the same one yeah.

ℹ Building target commonjs
ℹ Cleaning up previous build at lib/commonjs
ℹ Compiling 37 files in src with babel
✔ Wrote files to lib/commonjs
ℹ Building target module
ℹ Cleaning up previous build at lib/module
ℹ Compiling 37 files in src with babel
✔ Wrote files to lib/module
ℹ Building target typescript
ℹ Cleaning up previous build at lib/typescript
ℹ Generating type definitions with tsc
error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.


Found 1 error.

✖ Failed to build definition files.
bob build

build files for publishing

Options:
  --help     Show help                                                 [boolean]
  --version  Show version number                                       [boolean]

Error: Failed to build definition files.```

[satya164]

If you want to use a different tsconfig (e.g. tsconfig.build.json) then you need to configure bob to use it https://callstack.github.io/react-native-builder-bob/build#typescript

[nsmet]

ah ok, thought it auto-detected it. Seems to do the trick!

Thanks so much for the quick response!! Might get this SDK out the door today still 🎉