-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold a React Native library: Nitro module #768
Comments
Hey @mrousavy have you folks hit this problem before? Looks like removing |
Hey - you need to import About the |
I wasn't familiar with that annotation, I just removed it to make it work. As for the step related to nitrogen, it would be good to clarify this step in the documentation so there are no doubts about what to do. Thanks for the support 😃 |
Not a bad one TBH @satya164 any thoughts on this? |
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary - Fixes #768 <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> ### Test plan <!-- List the steps with which we can test this change. Provide screenshots if this changes anything visual. -->
Description
After generated project, i followed steps:
Get started with the project:
Run the example app on iOS:
Run the example app on Android:
I ran the command:
I got the error:
the folder nitrogen was not generated
but since I know a little about Nitro, I already knew what I should do and I accessed it: https://nitro.margelo.com/docs/nitrogen#configuration
after running the command in the root of the project
the folder nitrogen was generated
and I re-ran the command
I got the error
When I opened the file in question, I saw the code and removed the annotation
I re-ran the command
the project ran without problems
PS: link repository without my change in AwesomeLibraryNitro.kt
Packages
Selected options
Nitro Module
Link to repro
https://github.com/mensonones/awesome-library-nitro
Environment
npx react-native info
info Fetching system and libraries information...
System:
OS: Linux 6.8 Ubuntu 22.04.5 LTS 22.04.5 LTS (Jammy Jellyfish)
CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
Memory: 15.98 GB / 31.13 GB
Shell:
version: 5.1.16
path: /bin/bash
Binaries:
Node:
version: 20.12.2
path: /usr/local/bin/node
Yarn:
version: 3.6.1
path: /usr/local/bin/yarn
npm:
version: 10.5.0
path: /usr/local/bin/npm
Watchman:
version: 4.9.0
path: /usr/bin/watchman
SDKs:
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Languages:
Java:
version: 17.0.14
path: /usr/bin/javac
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 15.1.3
wanted: ^15.1.3
react:
installed: 18.3.1
wanted: 18.3.1
react-native: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: Not found
newArchEnabled: Not found
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
The text was updated successfully, but these errors were encountered: