Skip to content

Commit f35cf37

Browse files
authored
fix: remove unused image loader (#151)
* fix: remove unused image loader * feat: ✨ add devmoji
1 parent 52b8415 commit f35cf37

File tree

7 files changed

+171
-153
lines changed

7 files changed

+171
-153
lines changed

apps/example/ios/Podfile.lock

+137-137
Large diffs are not rendered by default.

lefthook.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ commit-msg:
1111
parallel: true
1212
commands:
1313
commitlint:
14-
run: npx commitlint --edit
14+
run: npx commitlint --edit && npx devmoji -e --lint

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"devDependencies": {
2727
"@commitlint/config-conventional": "^17.0.2",
2828
"commitlint": "^17.0.2",
29+
"devmoji": "^2.3.0",
2930
"eslint": "^8.51.0",
3031
"eslint-config-prettier": "^9.0.0",
3132
"eslint-plugin-prettier": "^5.0.1",

packages/react-native-bottom-tabs/ios/Fabric/RCTTabViewComponentView.mm

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ - (instancetype)initWithFrame:(CGRect)frame
4444
if (self = [super initWithFrame:frame]) {
4545
static const auto defaultProps = std::make_shared<const RNCTabViewProps>();
4646
_reactSubviews = [NSMutableArray new];
47-
RCTImageLoader *imageLoader = [[RCTBridge currentBridge] moduleForName:@"ImageLoader"];
48-
_tabViewProvider = [[TabViewProvider alloc] initWithDelegate:self imageLoader:imageLoader];
47+
_tabViewProvider = [[TabViewProvider alloc] initWithDelegate:self];
4948
self.contentView = _tabViewProvider;
5049
_props = defaultProps;
5150
}

packages/react-native-bottom-tabs/ios/RCTTabViewViewManager.mm

+1-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ - (void)onPageSelectedWithKey:(NSString *)key reactTag:(NSNumber *)reactTag {
6161

6262
- (UIView *)view
6363
{
64-
RCTImageLoader *imageLoader = [self.bridge moduleForClass:[RCTImageLoader class]];
65-
return [[TabViewProvider alloc] initWithDelegate:self imageLoader:imageLoader];
64+
return [[TabViewProvider alloc] initWithDelegate:self];
6665
}
6766

6867
@end

packages/react-native-bottom-tabs/ios/TabViewProvider.swift

+1-3
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import SDWebImageSVGCoder
4141
private var props = TabViewProps()
4242
private var hostingController: UIHostingController<TabViewImpl>?
4343
private var coalescingKey: UInt16 = 0
44-
private var imageLoader: RCTImageLoaderProtocol?
4544
private var iconSize = CGSize(width: 27, height: 27)
4645

4746
@objc var onPageSelected: RCTDirectEventBlock?
@@ -159,10 +158,9 @@ import SDWebImageSVGCoder
159158
}
160159
}
161160

162-
@objc public convenience init(delegate: TabViewProviderDelegate, imageLoader: RCTImageLoader) {
161+
@objc public convenience init(delegate: TabViewProviderDelegate) {
163162
self.init()
164163
self.delegate = delegate
165-
self.imageLoader = imageLoader
166164
SDImageCodersManager.shared.addCoder(SDImageSVGCoder.shared)
167165
}
168166

yarn.lock

+29-8
Original file line numberDiff line numberDiff line change
@@ -2999,6 +2999,7 @@ __metadata:
29992999
dependencies:
30003000
"@commitlint/config-conventional": ^17.0.2
30013001
commitlint: ^17.0.2
3002+
devmoji: ^2.3.0
30023003
eslint: ^8.51.0
30033004
eslint-config-prettier: ^9.0.0
30043005
eslint-plugin-prettier: ^5.0.1
@@ -7149,7 +7150,7 @@ __metadata:
71497150
languageName: node
71507151
linkType: hard
71517152

7152-
"chalk@npm:4, chalk@npm:^4.0.0, chalk@npm:^4.1.0, chalk@npm:^4.1.2":
7153+
"chalk@npm:4, chalk@npm:^4.0.0, chalk@npm:^4.1.0, chalk@npm:^4.1.1, chalk@npm:^4.1.2":
71537154
version: 4.1.2
71547155
resolution: "chalk@npm:4.1.2"
71557156
dependencies:
@@ -7588,6 +7589,13 @@ __metadata:
75887589
languageName: node
75897590
linkType: hard
75907591

7592+
"commander@npm:7.2.0, commander@npm:^7.2.0":
7593+
version: 7.2.0
7594+
resolution: "commander@npm:7.2.0"
7595+
checksum: 53501cbeee61d5157546c0bef0fedb6cdfc763a882136284bed9a07225f09a14b82d2a84e7637edfd1a679fb35ed9502fd58ef1d091e6287f60d790147f68ddc
7596+
languageName: node
7597+
linkType: hard
7598+
75917599
"commander@npm:^2.20.0":
75927600
version: 2.20.3
75937601
resolution: "commander@npm:2.20.3"
@@ -7609,13 +7617,6 @@ __metadata:
76097617
languageName: node
76107618
linkType: hard
76117619

7612-
"commander@npm:^7.2.0":
7613-
version: 7.2.0
7614-
resolution: "commander@npm:7.2.0"
7615-
checksum: 53501cbeee61d5157546c0bef0fedb6cdfc763a882136284bed9a07225f09a14b82d2a84e7637edfd1a679fb35ed9502fd58ef1d091e6287f60d790147f68ddc
7616-
languageName: node
7617-
linkType: hard
7618-
76197620
"commander@npm:^9.4.1":
76207621
version: 9.5.0
76217622
resolution: "commander@npm:9.5.0"
@@ -8424,6 +8425,19 @@ __metadata:
84248425
languageName: node
84258426
linkType: hard
84268427

8428+
"devmoji@npm:^2.3.0":
8429+
version: 2.3.0
8430+
resolution: "devmoji@npm:2.3.0"
8431+
dependencies:
8432+
chalk: ^4.1.1
8433+
commander: 7.2.0
8434+
ts-interface-checker: 1.0.0
8435+
bin:
8436+
devmoji: bin/devmoji.js
8437+
checksum: 8b13866422085ac6834ffcd66fc342bb56b3128d0909647c00b475d29e11be83e6035f7ffcfeca3bcfec7299a0d3e3b3b84265993885d1aff33e3fc5467f2687
8438+
languageName: node
8439+
linkType: hard
8440+
84278441
"diff-sequences@npm:^29.6.3":
84288442
version: 29.6.3
84298443
resolution: "diff-sequences@npm:29.6.3"
@@ -19310,6 +19324,13 @@ __metadata:
1931019324
languageName: node
1931119325
linkType: hard
1931219326

19327+
"ts-interface-checker@npm:1.0.0":
19328+
version: 1.0.0
19329+
resolution: "ts-interface-checker@npm:1.0.0"
19330+
checksum: 3cf0b6037f3ccd6f6df1c963ce4dcff4ab540129b24d4f662b4df82abdd287276b2795824221b4bc1ae68244f03f37de90458f256e94e9de572d00ddaa023ff7
19331+
languageName: node
19332+
linkType: hard
19333+
1931319334
"ts-interface-checker@npm:^0.1.9":
1931419335
version: 0.1.13
1931519336
resolution: "ts-interface-checker@npm:0.1.13"

0 commit comments

Comments
 (0)