Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CallForwardingSignal r1.1/2 release review #52

Closed
11 tasks done
tanjadegroot opened this issue Jul 25, 2024 · 4 comments
Closed
11 tasks done

CallForwardingSignal r1.1/2 release review #52

tanjadegroot opened this issue Jul 25, 2024 · 4 comments
Assignees
@tanjadegroot
Labels
review Review of a proposed release (e.g. release PR)

Comments

@tanjadegroot
Copy link
Collaborator

tanjadegroot commented Jul 25, 2024 •
edited by hdamker
Loading

Release PR or issue to review

Review actions

Assign this issue to yourself and follow the below list.
For any review action, review the file(s) in the issue/PR listed above.
Put comments in the above issue or PR if they concern non-changed files/text.
Put a short summary of the main review result here into the review issue.

  • API definition files (YAML) (check version in info & servers objects)
  • test file(s) availability
  • changelog updated
  • readme updated (enforce correct release number / API version naming)
  • API readiness checklist(s)

Release actions

Assign this issue to yourself or another RM team member and follow the below list.
When done, tick the box in this issue.

  • API release tracker available on wiki
  • Review comments addressed (by Sub Project)
  • Release PR approved (on behalf of Release Management)
  • PR merged (by Sub Project codeowner)
  • Release created within GitHub (by Sub Project codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

Additional comments
@tanjadegroot tanjadegroot added the review Review of a proposed release (e.g. release PR) label Jul 25, 2024
@tanjadegroot tanjadegroot changed the title CallForwardingSignal M3 Fall24 release review CallForwardingSignal r1.1 release review Jul 25, 2024
@tanjadegroot tanjadegroot self-assigned this Jul 25, 2024
@tanjadegroot
Copy link
Collaborator Author

Main review comments:

  • YAML: missing x-camara-commonalities
  • wrong version in test files
  • Herbert: r1.1 was released without RM review. Create a r1.2 with RM comments.
  • rename API readiness checklist file with full API name in front.

Beyond RM aspects, some suggestions:

  • User Stories: terminology rather Telco focused (Customer --> End-user, Operator Platform --> API Provider)
  • rename API to call-forwarding-status (iso call-forwarding-signal)

@hdamker
Copy link
Collaborator

hdamker commented Aug 6, 2024 •
edited
Loading

@hdamker
Copy link
Collaborator

hdamker commented Aug 7, 2024

Release r1.2 created and tracker updated.

@hdamker hdamker closed this as completed Aug 7, 2024
@hdamker hdamker changed the title CallForwardingSignal r1.1 release review CallForwardingSignal r1.1/2 release review Aug 7, 2024
@hdamker
Copy link
Collaborator

hdamker commented Aug 8, 2024

Plan for the M4 release: camaraproject/CallForwardingSignal#92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanjadegroot tanjadegroot

Labels
review Review of a proposed release (e.g. release PR)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hdamker @tanjadegroot