zsh: mcfly incorrectly parses multi-line zhistory entries

[durin42]

if you have a command typed as

echo foo \
  bar

that ends up as separate entries in mcfly, rather than a single one. It looks like mcfly is incorrectly parses the history entry? The relevant snippet for that from my .zsh_history is:

: 1593624164:0;echo foo \\
 bar

It looks like mcfly is getting confused by this, and I think it only gets the last line of the command.

[cantino]

Thanks @durin42, I think that is a bug.

[dithpri]

I'm experiencing the same issue

[lucidyan]

Same problem here, in my case mcfly became unusable for most cases because I have to use history | grep every time it appears.

[magnetophon]

Any news on this?

[cantino]

It hasn't been a priority for me since I don't use many multi-line commands, but I'm open to pull requests. #162 was a first attempt but someone needs to own it and test it.

[kentakom1213]

I've been working on this problem and have a mostly working implementation, but I've run into an issue with the specification of Zsh's command history.

I've found that two different scenarios are recorded in the history file as the same string.

The first scenario is two separate commands:

$ echo \\
$ echo hello

(These output \ and hello, respectively.)

The second scenario is a single multi-line command:

$ echo \
> echo hello

(This outputs echo hello.)

The problem is that both of these scenarios seem to be written to the ~/.zsh_history file as the following multi-line string:

echo \\
echo hello

@cantino -san, what would be the proper approach for this?

[cantino]

Hey @kentakom1213, do you know if you're using EXTENDED_HISTORY? Maybe we should require that?

[kentakom1213]

@cantino Hi, if that's possible, it might be a good idea. I'll try to implement the handling of newlines only when extended_history is enabled.