From 2d4201a41d90bca999097ffa0425b1fb67890ca0 Mon Sep 17 00:00:00 2001 From: Steffen Waldmann Date: Thu, 21 Nov 2024 16:37:44 +0100 Subject: [PATCH 1/3] Default `false` for `sslUseDefaultTrustStore` --- hana/package.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hana/package.json b/hana/package.json index 5f48d39e0..9e408a888 100644 --- a/hana/package.json +++ b/hana/package.json @@ -50,7 +50,14 @@ "impl": "@cap-js/hana" } }, - "db": "sql" + "db": { + "kind": "sql", + "[production]": { + "credentials": { + "sslUseDefaultTrustStore": false + } + } + } } }, "license": "SEE LICENSE" From 08b37e27501c3f54356913c58577d9ea0ca83ee3 Mon Sep 17 00:00:00 2001 From: Steffen Waldmann Date: Thu, 21 Nov 2024 16:43:00 +0100 Subject: [PATCH 2/3] Simpler --- hana/package.json | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hana/package.json b/hana/package.json index 9e408a888..a198eb0d7 100644 --- a/hana/package.json +++ b/hana/package.json @@ -43,21 +43,15 @@ "kinds": { "sql": { "[production]": { - "kind": "hana" + "kind": "hana", + "sslUseDefaultTrustStore": false } }, "hana": { "impl": "@cap-js/hana" } }, - "db": { - "kind": "sql", - "[production]": { - "credentials": { - "sslUseDefaultTrustStore": false - } - } - } + "db": "sql" } }, "license": "SEE LICENSE" From 0a63eb76e5014bbb51590e501fbec00da6c81b02 Mon Sep 17 00:00:00 2001 From: Steffen Waldmann Date: Fri, 22 Nov 2024 11:37:52 +0100 Subject: [PATCH 3/3] Move `sslUseDefaultTrustStore` to `hdb` driver --- hana/lib/drivers/hdb.js | 1 + hana/package.json | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hana/lib/drivers/hdb.js b/hana/lib/drivers/hdb.js index 5d8630c7c..bdc717fe3 100644 --- a/hana/lib/drivers/hdb.js +++ b/hana/lib/drivers/hdb.js @@ -23,6 +23,7 @@ class HDBDriver extends driver { constructor(creds) { creds = { fetchSize: 1 << 16, // V8 default memory page size + sslUseDefaultTrustStore: false, ...creds, } diff --git a/hana/package.json b/hana/package.json index a198eb0d7..5f48d39e0 100644 --- a/hana/package.json +++ b/hana/package.json @@ -43,8 +43,7 @@ "kinds": { "sql": { "[production]": { - "kind": "hana", - "sslUseDefaultTrustStore": false + "kind": "hana" } }, "hana": {