-
Notifications
You must be signed in to change notification settings - Fork 138
microservices - add missing directory #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| cds shared-db/db -2 hana | ||
| ``` | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cds deploy and cds build work w/o being in the folder?
Or would it make sense to include a cd shared-db step and not mention the folder with every command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, for the context of the 'Try it out' box a cd shared-db step could make sense.
cds build shared-db --for hana works, but cds deploy only works in the folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing directories can be confusing, a subsequent cd .. is also required, in addition the suggested change shows that the cds command in that case consumes a model and the db parameter is not a command but a directory with a cds model. Afterwards the guide continues in the root directory so better make sure we stay there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the cds compile command to make it more clear what happens,. It seems to be the default command, thus skipped.
cds compile shared-db/db --to hana
cds compile shared-db/db --to sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just uploaded the "cd shared-db" variant for the whole block - commands work now


No description provided.