Skip to content

Conversation

@vl-leon
Copy link
Contributor

@vl-leon vl-leon commented Jun 10, 2025

No description provided.

@vl-leon vl-leon requested a review from renejeglinsky as a code owner June 10, 2025 12:16
cds shared-db/db -2 hana
```

```sh
Copy link
Contributor

@renejeglinsky renejeglinsky Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does cds deploy and cds build work w/o being in the folder?
Or would it make sense to include a cd shared-db step and not mention the folder with every command?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, for the context of the 'Try it out' box a cd shared-db step could make sense.
cds build shared-db --for hana works, but cds deploy only works in the folder.

Copy link
Contributor Author

@vl-leon vl-leon Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing directories can be confusing, a subsequent cd .. is also required, in addition the suggested change shows that the cds command in that case consumes a model and the db parameter is not a command but a directory with a cds model. Afterwards the guide continues in the root directory so better make sure we stay there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 165 what does cds deploy deploy? This would then also need the "shared-db" as part of the command, or?
image

Same question for line 168.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the cds compile command to make it more clear what happens,. It seems to be the default command, thus skipped.

cds compile shared-db/db --to hana
cds compile shared-db/db --to sql

Copy link
Contributor Author

@vl-leon vl-leon Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 165 what does cds deploy deploy? This would then also need the "shared-db" as part of the command, or? image

Same question for line 168.

You are right, we need the models here also:

npx cds deploy -2 sqlite
No .cds models found, please specify one as an argument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just uploaded the "cd shared-db" variant for the whole block - commands work now

@renejeglinsky renejeglinsky added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 8fc9f38 Jun 17, 2025
4 checks passed
@renejeglinsky renejeglinsky deleted the microservices/add-missing-directory branch June 17, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants