Skip to content

Commit 497e25f

Browse files
captbaritonejberg
andauthored
Upgrade Butterchurn (#1059)
* Upgrade Butterchurn * Butterchurn beta.1 * Set useWASM for all methods of loading presets * Upgrade to butterchurn-presets 3.0.0 beta 1 * Only add useWASM to presets from butterchurn-presets * switch to unminified src for presets Co-authored-by: jberg <[email protected]>
1 parent 5f0a020 commit 497e25f

File tree

3 files changed

+49
-5
lines changed

3 files changed

+49
-5
lines changed

packages/webamp/demo/js/butterchurnOptions.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import { ButterchurnOptions } from "./Webamp";
22

3+
function addUseWASM(obj: Object): Object {
4+
return { ...obj, useWASM: true };
5+
}
6+
37
const KNOWN_PRESET_URLS_REGEXES = [
48
/^https:\/\/unpkg\.com\/butterchurn-presets\/.*\.json$/,
59
/^https:\/\/unpkg\.com\/butterchurn-presets-weekly\/.*\.json$/,
@@ -34,7 +38,7 @@ export function getButterchurnOptions(
3438
return {
3539
importButterchurn: () => {
3640
return import(
37-
/* webpackChunkName: "butterchurn-initial-dependencies" */
41+
/* webpackChunkName: "butterchurn" */
3842
// @ts-ignore
3943
"butterchurn"
4044
);
@@ -89,10 +93,15 @@ export function getButterchurnOptions(
8993
throw new Error("We still need to implement this");
9094
}
9195
}
92-
// TODO: Fallback to some other presets?
93-
return loadButterchurnPresetMapURL(
94-
"https://unpkg.com/[email protected]/weeks/week1/presets.json"
96+
97+
const presets = await import(
98+
/* webpackChunkName: "butterchurn-presets" */
99+
// @ts-ignore
100+
"butterchurn-presets/src/minimal.js"
95101
);
102+
return Object.entries(presets.default).map(([name, preset]) => {
103+
return { name, butterchurnPresetObject: addUseWASM(preset as Object) };
104+
});
96105
},
97106
butterchurnOpen: !startWithMilkdropHidden,
98107
};

packages/webamp/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@
135135
},
136136
"dependencies": {
137137
"ani-cursor": "^0.0.4",
138-
"butterchurn": "^2.6.7",
138+
"butterchurn": "^3.0.0-beta.1",
139+
"butterchurn-presets": "3.0.0-beta.1",
139140
"classnames": "^2.2.5",
140141
"fscreen": "^1.0.2",
141142
"invariant": "^2.2.3",

yarn.lock

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,11 @@
9292
"@algolia/logger-common" "4.3.0"
9393
"@algolia/requester-common" "4.3.0"
9494

95+
"@assemblyscript/loader@^0.17.11":
96+
version "0.17.14"
97+
resolved "https://registry.yarnpkg.com/@assemblyscript/loader/-/loader-0.17.14.tgz#43bfe793c787180c5eb0a57ada8318fb62171b4e"
98+
integrity sha512-+PVTOfla/0XMLRTQLJFPg4u40XcdTfon6GGea70hBGi8Pd7ZymIXyVUR+vK8wt5Jb4MVKTKPIz43Myyebw5mZA==
99+
95100
"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.8.3":
96101
version "7.8.3"
97102
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.8.3.tgz#33e25903d7481181534e12ec0a25f16b6fcf419e"
@@ -1797,6 +1802,13 @@
17971802
dependencies:
17981803
regenerator-runtime "^0.13.4"
17991804

1805+
"@babel/runtime@^7.11.2", "@babel/runtime@^7.12.5":
1806+
version "7.12.5"
1807+
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.12.5.tgz#410e7e487441e1b360c29be715d870d9b985882e"
1808+
integrity sha512-plcc+hbExy3McchJCEQG3knOsuh3HH+Prx1P6cLIkET/0dLuQDEnrT+s27Axgc9bqfsmNUNHfscgMUdBpC9xfg==
1809+
dependencies:
1810+
regenerator-runtime "^0.13.4"
1811+
18001812
"@babel/runtime@^7.12.1":
18011813
version "7.12.1"
18021814
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.12.1.tgz#b4116a6b6711d010b2dad3b7b6e43bf1b9954740"
@@ -4269,13 +4281,30 @@ busboy@^0.3.1:
42694281
dependencies:
42704282
dicer "0.3.0"
42714283

4284+
4285+
version "3.0.0-beta.1"
4286+
resolved "https://registry.yarnpkg.com/butterchurn-presets/-/butterchurn-presets-3.0.0-beta.1.tgz#8f2474f7857c7a6494476dec56dbd4255e1f4b0a"
4287+
integrity sha512-2/rBysBUNVdQviwQWDqEM+NtiAF55HwCHrPVmy65wh/ruGyUYuPZpp/pNUCyCsQAdajfPVcjViqkNBThdzHhDA==
4288+
dependencies:
4289+
"@babel/runtime" "^7.12.5"
4290+
42724291
butterchurn@^2.6.7:
42734292
version "2.6.7"
42744293
resolved "https://registry.yarnpkg.com/butterchurn/-/butterchurn-2.6.7.tgz#1ff0c1365731a4fb7ada7bb16ae1c6f09a110c12"
42754294
dependencies:
42764295
"@babel/runtime" "^7.0.0"
42774296
ecma-proposal-math-extensions "0.0.2"
42784297

4298+
butterchurn@^3.0.0-beta.1:
4299+
version "3.0.0-beta.1"
4300+
resolved "https://registry.yarnpkg.com/butterchurn/-/butterchurn-3.0.0-beta.1.tgz#b7e5b1a2168ce041a2a0b1771b23d958002b331e"
4301+
integrity sha512-crY/ppARjwHR6f6PcSIjvDgm1OrzTHdJa9ubAPZzOSsp/ohEanCIn1xhrUOSFT4c7rRKL7c3yqANICZMQAOh2w==
4302+
dependencies:
4303+
"@assemblyscript/loader" "^0.17.11"
4304+
"@babel/runtime" "^7.11.2"
4305+
ecma-proposal-math-extensions "0.0.2"
4306+
eel-wasm "^0.0.12"
4307+
42794308
[email protected], byte-data@^18.0.3:
42804309
version "18.1.1"
42814310
resolved "https://registry.yarnpkg.com/byte-data/-/byte-data-18.1.1.tgz#4eed09970921bf7d786b250e56615d8314bb6746"
@@ -5772,6 +5801,11 @@ [email protected]:
57725801
version "1.1.1"
57735802
resolved "https://registry.yarnpkg.com/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d"
57745803

5804+
eel-wasm@^0.0.12:
5805+
version "0.0.12"
5806+
resolved "https://registry.yarnpkg.com/eel-wasm/-/eel-wasm-0.0.12.tgz#7bec69b6d7e1573cc1fc4d4ad65e92713dee79e1"
5807+
integrity sha512-FgC/P8j6b9hwMzerko+ixrdeWKN/kFR15FPNWUZ/ngtsMK84sD479385ccTywyAR47jegXompUGpqbWTGn7kIw==
5808+
57755809
ejs@^2.6.1:
57765810
version "2.7.4"
57775811
resolved "https://registry.yarnpkg.com/ejs/-/ejs-2.7.4.tgz#48661287573dcc53e366c7a1ae52c3a120eec9ba"

0 commit comments

Comments
 (0)