Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binstalk-downloader cannot decode some zip files on macos (x64 and arm64) platforms #2049

Open
ahaoboy opened this issue Feb 13, 2025 · 2 comments
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)

Comments

@ahaoboy
Copy link

ahaoboy commented Feb 13, 2025

https://github.com/ahaoboy/download-extract/actions/runs/13302717471/job/37146927245

I want to use binstalk-downloader for secondary development and decompress some compressed files, but I found that bun zip files will report errors when decompressing on macos platforms, but they work correctly on windows and unbuntu platforms

Could this be because a feature of a dependent library is not enabled?

include:
  - bun: https://github.com/oven-sh/bun/releases/latest/download/bun-darwin-x64.zip
    binstall: https://github.com/cargo-bins/cargo-binstall/releases/download/v1.10.23/cargo-binstall-x86_64-apple-darwin.full.zip
    bunName: bun.zip
    binstallName: binstall.zip
    os: macos-13
  - bun: https://github.com/oven-sh/bun/releases/latest/download/bun-darwin-aarch64.zip
    binstall: https://github.com/cargo-bins/cargo-binstall/releases/download/v1.10.23/cargo-binstall-aarch64-apple-darwin.full.zip
    os: macos-14
    bunName: bun.zip
    binstallName: binstall.zip
  - bun: https://github.com/oven-sh/bun/releases/latest/download/bun-windows-x64.zip
    binstall: https://github.com/cargo-bins/cargo-binstall/releases/download/v1.10.23/cargo-binstall-x86_64-pc-windows-msvc.full.zip
    os: windows-latest
    bunName: bun.zip
    binstallName: binstall.zip
  - bun: https://github.com/oven-sh/bun/releases/latest/download/bun-linux-x64-baseline.zip
    binstall: https://github.com/cargo-bins/cargo-binstall/releases/download/v1.10.23/cargo-binstall-x86_64-unknown-linux-gnu.full.tgz
    os: ubuntu-24.04
    bunName: bun.zip
    binstallName: binstall.tgz

These two files cannot be decompressed on the macos platform

https://github.com/oven-sh/bun/releases/latest/download/bun-darwin-x64.zip
https://github.com/oven-sh/bun/releases/latest/download/bun-darwin-aarch64.zip
@NobodyXu
Copy link
Member

NobodyXu commented Feb 13, 2025

Hello, thanks for reporting!

It's a strange bug indeed, we don't have any macos specific code

https://github.com/cargo-bins/cargo-binstall/blob/main/crates/binstalk-downloader/src/download/zip_extraction.rs

Since the error comes from rc-zip, it looks like a bug in upstream

@ahaoboy
Copy link
Author

ahaoboy commented Feb 13, 2025

Yes, I reproduced this bug in the rc-zip repository, and it seems that we can only wait for the upstream to fix it.

@NobodyXu NobodyXu added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)
Projects
None yet
Development

No branches or pull requests

2 participants