Skip to content

Commit f4972eb

Browse files
author
Muriel Picone Farías
committed
[WIP] Try to connect spans into traces
1 parent 4b2d582 commit f4972eb

File tree

1 file changed

+7
-8
lines changed
  • instrumentation/grape/lib/opentelemetry/instrumentation/grape

1 file changed

+7
-8
lines changed

instrumentation/grape/lib/opentelemetry/instrumentation/grape/handler.rb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ def subscribe
2929
private
3030

3131
def endpoint_run_start(name, start, finish, id, payload)
32-
puts 'TEST RUN START'
33-
end
34-
35-
def endpoint_run(name, start, finish, id, payload)
3632
# TODO: check span.name and span.type, and set service.name
3733
env = payload.fetch(:env)
3834
# TODO: see if we need to use symbol_key_getter instead
@@ -41,13 +37,16 @@ def endpoint_run(name, start, finish, id, payload)
4137
env,
4238
getter: OpenTelemetry::Common::Propagation.rack_env_getter
4339
)
44-
OpenTelemetry::Context.with_current(extracted_context) do
45-
tracer.in_span(name, attributes: build_run_attributes(payload), kind: :server) {}
46-
end
40+
tracer.start_span(name, with_parent: extracted_context, attributes: build_run_attributes(payload), kind: :server)
41+
end
42+
43+
def endpoint_run(name, start, finish, id, payload)
44+
# This is not working because we are not getting the span started in endpoint_run_start
45+
span = OpenTelemetry::Trace.current_span
46+
span.finish
4747
end
4848

4949
def endpoint_render_start(name, start, finish, id, payload)
50-
puts 'TEST RENDER START'
5150
end
5251

5352
def endpoint_render(name, start, finish, id, payload)

0 commit comments

Comments
 (0)