Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Redis pipelining and multiple get requests #160

Open
zainab-ali opened this issue Jan 15, 2018 · 6 comments
Open

Support for Redis pipelining and multiple get requests #160

zainab-ali opened this issue Jan 15, 2018 · 6 comments

Comments

@zainab-ali
Copy link

There are a couple of features which would be useful for REDIS. In particular:

  • getting and setting multiple keys in the same request
  • pipelining (issuing multiple operations in the same request)

AFAIK, this is supported by jedis. I'd be happy to have a go at adding these.

@cb372
Copy link
Owner

cb372 commented Jan 16, 2018

Hi Zainab 👋

Sure, I'd be happy to see a PR for this.

I'll be interested to see what kind of API you come up with for it, as I don't think any other backends support these features. ScalaCache often runs in to problems like this: how do you support the advanced features of some backends without having an adverse effect on people who want to use other backends?

By the way there is already an issue (#130) for getting multiple keys. Ignore my comment on that issue - I misunderstood and thought Sam wanted to get every single item in the cache in one call.

@zainab-ali
Copy link
Author

Yes, it's going to be tricky to implement. Abstracting over all cache APIs gives the lowest common denominator, but that's not necessarily what would be most useful. I'll see what I can come up with.

@dmvieira
Copy link

dmvieira commented Jun 20, 2018

I think it's an advanced usage of Scala Cache and by now, IMO, we could turn backend public to advanced functions usage. What do you think?

@augi
Copy link
Contributor

augi commented Apr 25, 2019

I'm willing to implement the multiple-key feature. I would implement it just for Redis now, so it would be implemented as new methods in RedisCacheBase class.

Would you mind accepting this kind of PR, @cb372, please?

@Habitats
Copy link

@augi status on this? Would really love multi-key methods for put/get. Not having it is a major bottleneck for us.

@augi
Copy link
Contributor

augi commented Jan 21, 2020

We derived the RedisCache class in our project and added these methods there.
I could prepare a new PR but I haven't got confirmation if a PR like this were accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants