Clean up debugging console log messages (openhab#676)

ghys · web-flow · commit 1c41a91bb123 · 2020-12-20T14:25:55.000+01:00
Remove most of the debug logging in the Javascript console,
or adjust the log levels.

Signed-off-by: Yannick Schaus &lt;github@schaus.net&gt;
diff --git a/bundles/org.openhab.ui/web/src/components/config/controls/parameter-dayofweek.vue b/bundles/org.openhab.ui/web/src/components/config/controls/parameter-dayofweek.vue
@@ -29,7 +29,6 @@ export default {
       if (!value) newValuesSet.delete(day)
       let newValues = new Array(...newValuesSet).sort((a, b) => this.values.indexOf(a) < this.values.indexOf(b))
       newValues.sort((a, b) => this.values.indexOf(a) - this.values.indexOf(b))
-      console.log(newValues)
       this.$emit('input', newValues)
     }
   }
diff --git a/bundles/org.openhab.ui/web/src/components/config/controls/script-editor.vue b/bundles/org.openhab.ui/web/src/components/config/controls/script-editor.vue
@@ -308,7 +308,6 @@ export default {
     }
   },
   mounted () {
-    // console.log('codemirror ready: ', this.codemirror)
   }
 }
 </script>
diff --git a/bundles/org.openhab.ui/web/src/components/expandable-card.vue b/bundles/org.openhab.ui/web/src/components/expandable-card.vue
@@ -225,11 +225,9 @@ export default {
   },
   methods: {
     cardOpening () {
-      console.log('card opened')
       setTimeout(() => { this.opened = true }, 200)
     },
     cardClosed () {
-      console.log('card closed')
       this.opened = false
     }
   }
diff --git a/bundles/org.openhab.ui/web/src/components/model/link-details.vue b/bundles/org.openhab.ui/web/src/components/model/link-details.vue
@@ -75,7 +75,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('page closed')
             }
           }
         }
@@ -96,7 +95,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('page closed')
             }
           }
         }
@@ -116,7 +114,6 @@ export default {
       }
     },
     links () {
-      console.log('LinkDetails: links changed')
       this.load()
     }
   }
diff --git a/bundles/org.openhab.ui/web/src/components/tags/semantics-picker.vue b/bundles/org.openhab.ui/web/src/components/tags/semantics-picker.vue
@@ -64,7 +64,6 @@ export default {
     itemChanged (item) {
       this.show = false
       if (!item.tags) return
-      // console.log(item.tags)
       this.semanticClass = ''
       this.semanticProperty = ''
       item.tags.forEach((t) => {
diff --git a/bundles/org.openhab.ui/web/src/components/thing/channel-group.vue b/bundles/org.openhab.ui/web/src/components/thing/channel-group.vue
@@ -66,7 +66,6 @@ export default {
       return ''
     },
     opened (channel) {
-      console.log('channel opened:' + channel.id)
       this.$emit('channel-opened', {
         channelId: channel.id,
         channel: channel
diff --git a/bundles/org.openhab.ui/web/src/components/thing/channel-link.vue b/bundles/org.openhab.ui/web/src/components/thing/channel-link.vue
@@ -108,7 +108,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('page closed')
               // const finalChannel = page.app.data.finalChannel
               // if (finalChannel) {
               //   delete page.app.data.finalChannel
@@ -138,7 +137,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('page closed')
             }
           }
         }
diff --git a/bundles/org.openhab.ui/web/src/components/thing/channel-list.vue b/bundles/org.openhab.ui/web/src/components/thing/channel-list.vue
@@ -178,7 +178,6 @@ export default {
       return channel.linkedItems && channel.linkedItems.length > 0
     },
     toggleItemCheck (channel, channelType) {
-      console.log('toggle check')
       if (this.isChecked(channel)) {
         this.selectedChannels.splice(this.selectedChannels.indexOf(channel), 1)
         this.newItems.splice(this.newItems.findIndex((i) => i.channel === channel), 1)
@@ -220,7 +219,6 @@ export default {
       return this.newItems.find((i) => i.channel === channel)
     },
     channelOpened (payload) {
-      console.log('caught channel-opened')
       this.openedChannelId = payload.channelId
       this.openedChannel = payload.channel
     }
diff --git a/bundles/org.openhab.ui/web/src/components/widgets/chart/misc/oh-chart-tooltip.js b/bundles/org.openhab.ui/web/src/components/widgets/chart/misc/oh-chart-tooltip.js
@@ -10,7 +10,6 @@ export default {
 
     if (component.config.smartFormatter) {
       options.formatter = (params, ticket, callback) => {
-        // console.log(params)
         let tooltip = ''
         if (params.componentType === 'markArea') {
           tooltip += `<div>${dayjs(params.data.coord[0][0]).format('llll')}<br />${dayjs(params.data.coord[1][0]).format('llll')}</div>`
diff --git a/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue b/bundles/org.openhab.ui/web/src/components/widgets/chart/oh-chart-page.vue
@@ -118,7 +118,6 @@ export default {
         value: [value],
         on: {
           change (calendar, value) {
-            console.log(value)
             if (value.length < 1) return
             if (dayjs(value[0]).isSame(self.startTime)) return
             self.setDate(value[0])
diff --git a/bundles/org.openhab.ui/web/src/js/openhab/speech.js b/bundles/org.openhab.ui/web/src/js/openhab/speech.js
@@ -26,7 +26,6 @@ export default {
     }
     wksr.onresult = (event) => {
       if (Framework7.device.android) {
-        console.log(event.results)
         let bestConfidence = 0
         for (let result of event.results) {
           for (let alternative of result) {
@@ -38,7 +37,6 @@ export default {
         }
         resultCallback({ final: false, text: interimResult })
       } else {
-        console.log(event.results)
         interimResult = ''
         for (let result of event.results) {
           if (result.isFinal) {
diff --git a/bundles/org.openhab.ui/web/src/js/openhab/sse.js b/bundles/org.openhab.ui/web/src/js/openhab/sse.js
@@ -18,8 +18,7 @@ function newSSEConnection (path, readyCallback, messageCallback, errorCallback)
   }
 
   eventSource.onerror = () => {
-    console.log('SSE error')
-    console.log(eventSource)
+    console.warn('SSE error')
     if (errorCallback) {
       errorCallback()
     }
@@ -29,7 +28,7 @@ function newSSEConnection (path, readyCallback, messageCallback, errorCallback)
   }
 
   openSSEClients.push(eventSource)
-  console.log(`new SSE connection: ${eventSource.url}, ${openSSEClients.length} open`)
+  console.debug(`new SSE connection: ${eventSource.url}, ${openSSEClients.length} open`)
   console.debug(openSSEClients)
   return eventSource
 }
@@ -46,7 +45,7 @@ export default {
     if (openSSEClients.indexOf(client) >= 0) {
       openSSEClients.splice(openSSEClients.indexOf(client), 1)
     }
-    console.log(`SSE connection closed: ${client.url}, ${openSSEClients.length} open`)
+    console.debug(`SSE connection closed: ${client.url}, ${openSSEClients.length} open`)
     console.debug(openSSEClients)
 
     client.close()
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/addons/addons-add.vue b/bundles/org.openhab.ui/web/src/pages/settings/addons/addons-add.vue
@@ -95,7 +95,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/addons/*/*', null, (event) => {
-        console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[3]) {
           case 'installed':
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/items/items-list-vlist.vue b/bundles/org.openhab.ui/web/src/pages/settings/items/items-list-vlist.vue
@@ -165,7 +165,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/items/*/added,openhab/items/*/removed,openhab/items/*/updated', null, (event) => {
-        console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[3]) {
           case 'added':
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/items/parser/items-add-from-textual-definition.vue b/bundles/org.openhab.ui/web/src/pages/settings/items/parser/items-add-from-textual-definition.vue
@@ -169,7 +169,7 @@ export default {
             // remove existing links unless they're about to be recreated
             item.existingLinks.forEach((el) => {
               if (item.links && item.links.some((l) => l === el.channelUID || (l.value === el.channelUID))) return
-              console.log(`DELETE /rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`)
+              console.debug(`DELETE /rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`)
               linksAndMetadataPromises.push(this.$oh.api.delete(`/rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`))
             })
           }
@@ -187,7 +187,7 @@ export default {
                 channelUID: channelUID,
                 configuration: config
               }
-              console.log(`PUT ${url}: ` + JSON.stringify(linkPayload))
+              console.debug(`PUT ${url}: ` + JSON.stringify(linkPayload))
               linksAndMetadataPromises.push(this.$oh.api.put(url, linkPayload))
             })
           }
@@ -204,7 +204,7 @@ export default {
                 value: value,
                 config: config
               }
-              console.log(`PUT ${url}` + JSON.stringify(metadataPayload))
+              console.debug(`PUT ${url}` + JSON.stringify(metadataPayload))
               linksAndMetadataPromises.push(this.$oh.api.put(url, metadataPayload))
             })
           }
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/model/model.vue b/bundles/org.openhab.ui/web/src/pages/settings/model/model.vue
@@ -314,7 +314,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/items/*/added,openhab/items/*/updated,openhab/items/*/removed', null, (event) => {
-        console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[3]) {
           case 'added':
@@ -475,7 +474,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('Add from thing page closed')
             }
           }
         }
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/rules/rule-edit.vue b/bundles/org.openhab.ui/web/src/pages/settings/rules/rule-edit.vue
@@ -354,7 +354,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/rules/' + this.ruleId + '/*', null, (event) => {
-        console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[3]) {
           case 'state':
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/schedule/schedule.vue b/bundles/org.openhab.ui/web/src/pages/settings/schedule/schedule.vue
@@ -174,7 +174,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/rules/*/*', null, (event) => {
-        console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[3]) {
           case 'added':
@@ -196,7 +195,6 @@ export default {
       return this.selectedItems.indexOf(item) >= 0
     },
     toggleItemCheck (event, item) {
-      console.log('toggle check')
       if (this.isChecked(item)) {
         this.selectedItems.splice(this.selectedItems.indexOf(item), 1)
       } else {
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/inbox/inbox-list.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/inbox/inbox-list.vue
@@ -186,7 +186,6 @@ export default {
     },
     startEventSource () {
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/inbox/*', null, (event) => {
-        console.log(event)
         // const topicParts = event.topic.split('/')
         this.load()
       })
@@ -228,7 +227,6 @@ export default {
               color: 'green',
               bold: true,
               onClick: () => {
-                console.log(`Add ${entry.thingUID} as thing`)
                 this.$f7.dialog.prompt(`This will create a new Thing of type ${entry.thingTypeUID} with the following name:`,
                   'Add as Thing',
                   (name) => {
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/link/link-add.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/link/link-add.vue
@@ -193,7 +193,7 @@ export default {
         this.profileTypeConfiguration = data
       }).catch((err) => {
         // just clear out the config sheet
-        console.log(`No configuration for profile type ${profileTypeUid}: ` + err)
+        console.warn(`No configuration for profile type ${profileTypeUid}: ` + err)
         this.profileTypeConfiguration = null
       })
     },
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue
@@ -301,7 +301,6 @@ export default {
       }
       // When coming back from the channel add/edit page with a change, let the handler below take care of the reloading logic (the thing has to be saved first)
       if (!event.pageFrom || !event.pageFrom.name || event.pageFrom.name.indexOf('channel') < 0) {
-        console.log('Loading')
         if (!this.eventSource) this.stopEventSource()
         this.load()
       }
@@ -426,7 +425,6 @@ export default {
         `${action.label}?`,
         this.thing.label,
         () => {
-          console.log(action)
           thing.configuration[action.name] = true
           this.dirty = true
           save()
@@ -537,7 +535,6 @@ export default {
           },
           on: {
             pageAfterOut (event, page) {
-              console.log('Add to model page closed')
             }
           }
         }
@@ -601,7 +598,6 @@ export default {
     startEventSource () {
       if (this.eventSource) this.stopEventSource()
       this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/things/*/*,openhab/links/*/*' /* + encodeURIComponent(this.thingId) */, null, (event) => {
-        // console.log(event)
         const topicParts = event.topic.split('/')
         switch (topicParts[1]) {
           case 'things':

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ export default {`
`29`	`29`	`if (!value) newValuesSet.delete(day)`
`30`	`30`	`let newValues = new Array(...newValuesSet).sort((a, b) => this.values.indexOf(a) < this.values.indexOf(b))`
`31`	`31`	`newValues.sort((a, b) => this.values.indexOf(a) - this.values.indexOf(b))`
`32`		`- console.log(newValues)`
`33`	`32`	`this.$emit('input', newValues)`
`34`	`33`	`}`
`35`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,6 @@ export default {`
`308`	`308`	`}`
`309`	`309`	`},`
`310`	`310`	`mounted () {`
`311`		`- // console.log('codemirror ready: ', this.codemirror)`
`312`	`311`	`}`
`313`	`312`	`}`
`314`	`313`	`</script>`
Original file line number	Diff line number	Diff line change
`@@ -225,11 +225,9 @@ export default {`
`225`	`225`	`},`
`226`	`226`	`methods: {`
`227`	`227`	`cardOpening () {`
`228`		`- console.log('card opened')`
`229`	`228`	`setTimeout(() => { this.opened = true }, 200)`
`230`	`229`	`},`
`231`	`230`	`cardClosed () {`
`232`		`- console.log('card closed')`
`233`	`231`	`this.opened = false`
`234`	`232`	`}`
`235`	`233`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ export default {`
`75`	`75`	`},`
`76`	`76`	`on: {`
`77`	`77`	`pageAfterOut (event, page) {`
`78`		`- console.log('page closed')`
`79`	`78`	`}`
`80`	`79`	`}`
`81`	`80`	`}`
`@@ -96,7 +95,6 @@ export default {`
`96`	`95`	`},`
`97`	`96`	`on: {`
`98`	`97`	`pageAfterOut (event, page) {`
`99`		`- console.log('page closed')`
`100`	`98`	`}`
`101`	`99`	`}`
`102`	`100`	`}`
`@@ -116,7 +114,6 @@ export default {`
`116`	`114`	`}`
`117`	`115`	`},`
`118`	`116`	`links () {`
`119`		`- console.log('LinkDetails: links changed')`
`120`	`117`	`this.load()`
`121`	`118`	`}`
`122`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,6 @@ export default {`
`108`	`108`	`},`
`109`	`109`	`on: {`
`110`	`110`	`pageAfterOut (event, page) {`
`111`		`- console.log('page closed')`
`112`	`111`	`// const finalChannel = page.app.data.finalChannel`
`113`	`112`	`// if (finalChannel) {`
`114`	`113`	`// delete page.app.data.finalChannel`
`@@ -138,7 +137,6 @@ export default {`
`138`	`137`	`},`
`139`	`138`	`on: {`
`140`	`139`	`pageAfterOut (event, page) {`
`141`		`- console.log('page closed')`
`142`	`140`	`}`
`143`	`141`	`}`
`144`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,7 @@ function newSSEConnection (path, readyCallback, messageCallback, errorCallback)`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`eventSource.onerror = () => {`
`21`		`- console.log('SSE error')`
`22`		`- console.log(eventSource)`
	`21`	`+ console.warn('SSE error')`
`23`	`22`	`if (errorCallback) {`
`24`	`23`	`errorCallback()`
`25`	`24`	`}`
`@@ -29,7 +28,7 @@ function newSSEConnection (path, readyCallback, messageCallback, errorCallback)`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`openSSEClients.push(eventSource)`
`32`		- console.log(`new SSE connection: ${eventSource.url}, ${openSSEClients.length} open`)
	`31`	+ console.debug(`new SSE connection: ${eventSource.url}, ${openSSEClients.length} open`)
`33`	`32`	`console.debug(openSSEClients)`
`34`	`33`	`return eventSource`
`35`	`34`	`}`
`@@ -46,7 +45,7 @@ export default {`
`46`	`45`	`if (openSSEClients.indexOf(client) >= 0) {`
`47`	`46`	`openSSEClients.splice(openSSEClients.indexOf(client), 1)`
`48`	`47`	`}`
`49`		- console.log(`SSE connection closed: ${client.url}, ${openSSEClients.length} open`)
	`48`	+ console.debug(`SSE connection closed: ${client.url}, ${openSSEClients.length} open`)
`50`	`49`	`console.debug(openSSEClients)`
`51`	`50`
`52`	`51`	`client.close()`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ export default {`
`169`	`169`	`// remove existing links unless they're about to be recreated`
`170`	`170`	`item.existingLinks.forEach((el) => {`
`171`	`171`	`if (item.links && item.links.some((l) => l === el.channelUID \|\| (l.value === el.channelUID))) return`
`172`		- console.log(`DELETE /rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`)
	`172`	+ console.debug(`DELETE /rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`)
`173`	`173`	linksAndMetadataPromises.push(this.$oh.api.delete(`/rest/links/${item.name}/${encodeURIComponent(el.channelUID)}`))
`174`	`174`	`})`
`175`	`175`	`}`
`@@ -187,7 +187,7 @@ export default {`
`187`	`187`	`channelUID: channelUID,`
`188`	`188`	`configuration: config`
`189`	`189`	`}`
`190`		- console.log(`PUT ${url}: ` + JSON.stringify(linkPayload))
	`190`	+ console.debug(`PUT ${url}: ` + JSON.stringify(linkPayload))
`191`	`191`	`linksAndMetadataPromises.push(this.$oh.api.put(url, linkPayload))`
`192`	`192`	`})`
`193`	`193`	`}`
`@@ -204,7 +204,7 @@ export default {`
`204`	`204`	`value: value,`
`205`	`205`	`config: config`
`206`	`206`	`}`
`207`		- console.log(`PUT ${url}` + JSON.stringify(metadataPayload))
	`207`	+ console.debug(`PUT ${url}` + JSON.stringify(metadataPayload))
`208`	`208`	`linksAndMetadataPromises.push(this.$oh.api.put(url, metadataPayload))`
`209`	`209`	`})`
`210`	`210`	`}`
Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,6 @@ export default {`
`314`	`314`	`},`
`315`	`315`	`startEventSource () {`
`316`	`316`	`this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/items//added,openhab/items//updated,openhab/items/*/removed', null, (event) => {`
`317`		`- console.log(event)`
`318`	`317`	`const topicParts = event.topic.split('/')`
`319`	`318`	`switch (topicParts[3]) {`
`320`	`319`	`case 'added':`
`@@ -475,7 +474,6 @@ export default {`
`475`	`474`	`},`
`476`	`475`	`on: {`
`477`	`476`	`pageAfterOut (event, page) {`
`478`		`- console.log('Add from thing page closed')`
`479`	`477`	`}`
`480`	`478`	`}`
`481`	`479`	`}`
Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,6 @@ export default {`
`301`	`301`	`}`
`302`	`302`	`// When coming back from the channel add/edit page with a change, let the handler below take care of the reloading logic (the thing has to be saved first)`
`303`	`303`	`if (!event.pageFrom \|\| !event.pageFrom.name \|\| event.pageFrom.name.indexOf('channel') < 0) {`
`304`		`- console.log('Loading')`
`305`	`304`	`if (!this.eventSource) this.stopEventSource()`
`306`	`305`	`this.load()`
`307`	`306`	`}`
`@@ -426,7 +425,6 @@ export default {`
`426`	`425`	`${action.label}?`,
`427`	`426`	`this.thing.label,`
`428`	`427`	`() => {`
`429`		`- console.log(action)`
`430`	`428`	`thing.configuration[action.name] = true`
`431`	`429`	`this.dirty = true`
`432`	`430`	`save()`
`@@ -537,7 +535,6 @@ export default {`
`537`	`535`	`},`
`538`	`536`	`on: {`
`539`	`537`	`pageAfterOut (event, page) {`
`540`		`- console.log('Add to model page closed')`
`541`	`538`	`}`
`542`	`539`	`}`
`543`	`540`	`}`
`@@ -601,7 +598,6 @@ export default {`
`601`	`598`	`startEventSource () {`
`602`	`599`	`if (this.eventSource) this.stopEventSource()`
`603`	`600`	`this.eventSource = this.$oh.sse.connect('/rest/events?topics=openhab/things//,openhab/links//' /* + encodeURIComponent(this.thingId) */, null, (event) => {`
`604`		`- // console.log(event)`
`605`	`601`	`const topicParts = event.topic.split('/')`
`606`	`602`	`switch (topicParts[1]) {`
`607`	`603`	`case 'things':`