Skip to content

Commit 96d9cdd

Browse files
committed
Fix metasrc path, add renata, upgrade Playwright
Updated to the new metasrc siteTemplate in background.js and the test path accordingly. Added an apparently new exception mapping for renata -> renata-glasc so lookups resolve correctly. Bump @playwright/test (and associated playwright packages) to 1.61.1 in package.json and package-lock.json.
1 parent e57d8d7 commit 96d9cdd

5 files changed

Lines changed: 18 additions & 17 deletions

File tree

app/background.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const siteTemplates = {
55
"lolalytics": "https://lolalytics.com/lol/{champ}/build/",
66
"mobalytics.gg": "https://mobalytics.gg/lol/champions/{champ}/build",
77
"poro.gg": "https://poro.gg/champions/{champ}",
8-
"metasrc": "https://www.metasrc.com/lol/build/{champ}"
8+
"metasrc": "https://www.metasrc.com/lol/champions/{champ}/build"
99
};
1010

1111
let cachedExceptions = null;

app/exceptions.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"leesin": "lee-sin",
1313
"masteryi": "master-yi",
1414
"missfortune": "miss-fortune",
15-
"xinzhao": "xin-zhao"
15+
"xinzhao": "xin-zhao",
16+
"renata": "renata-glasc"
1617
}
1718
}

package-lock.json

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"license": "ISC",
1515
"type": "commonjs",
1616
"devDependencies": {
17-
"@playwright/test": "^1.58.2",
17+
"@playwright/test": "^1.61.1",
1818
"@types/node": "^25.3.5"
1919
}
20-
}
20+
}

tests/champ-build.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const SITES = [
1515
{ name: "Lolalytics", key: "lolalytics", base: "https://lolalytics.com", path: (id) => { const siteId = (exceptions["lolalytics"] && exceptions["lolalytics"][id]) || id; return `/lol/${siteId}/build`; } },
1616
{ name: "Blitz", key: "blitz.gg", base: "https://blitz.gg", path: (id) => `/lol/champions/${id}/build` },
1717
{ name: "Poro", key: "poro.gg", base: "https://poro.gg", path: (id) => `/champions/${id}` },
18-
{ name: "Metasrc", key: "metasrc", base: "https://www.metasrc.com", path: (id) => { const siteId = (exceptions["metasrc"] && exceptions["metasrc"][id]) || id; return `/lol/build/${siteId}`; } }
18+
{ name: "Metasrc", key: "metasrc", base: "https://www.metasrc.com", path: (id) => { const siteId = (exceptions["metasrc"] && exceptions["metasrc"][id]) || id; return `/lol/champions/${siteId}/build`; } }
1919
];
2020

2121
async function runRedirectTest(page, context, siteKey, champ, name, expectedUrlPart, baseUrl) {

0 commit comments

Comments
 (0)