test: Fix unit tests to run independent of current env

* Save all intermediate coverage files in `/tmp` folder to minimize unwanted files in root directory

Author: mahendrapaipuri

Makefile

@@ -66,7 +66,7 @@ ifeq ($(CGO_APPS), 1)
 	checkbpf := skip-checkbpf
 
 	# go test flags
-	coverage-file := coverage-cgo.out
+	coverage-file := /tmp/coverage-cgo.out
 else
 	PROMU_CONF ?= .promu/.promu-go.yml
 	pkgs := ./pkg/collector ./pkg/emissions ./pkg/tsdb ./pkg/grafana ./pkg/k8s \
@@ -78,7 +78,7 @@ else
 	checkbpf := checkbpf
 
 	# go test flags
-	coverage-file := coverage-go.out
+	coverage-file := /tmp/coverage-go.out
 
 	# If running in CI add -exec sudo flags to run tests that require privileges
 	ifeq ($(CI), true)
@@ -122,12 +122,12 @@ all:: vet common-all $(checkbpf) $(cross-test) $(test-docker) $(checkmetrics) $(
 .PHONY: coverage
 coverage:
 	@echo ">> getting coverage reports"
-	$(GO) tool cover -html=coverage-go.out -o coverage-go.html
-	$(GO) tool cover -html=coverage-cgo.out -o coverage-cgo.html
-	cp coverage-go.out coverage-raw.out
-	tail -n +2 coverage-cgo.out >> coverage-raw.out
-	$(GO) tool cover -html=coverage-raw.out -o coverage.html
-	$(GO) tool cover -func=coverage-raw.out -o=coverage.out
+	$(GO) tool cover -html=/tmp/coverage-go.out -o coverage-go.html
+	$(GO) tool cover -html=/tmp/coverage-cgo.out -o coverage-cgo.html
+	cp /tmp/coverage-go.out /tmp/coverage-raw.out
+	tail -n +2 /tmp/coverage-cgo.out >> /tmp/coverage-raw.out
+	$(GO) tool cover -html=/tmp/coverage-raw.out -o=coverage.html
+	$(GO) tool cover -func=/tmp/coverage-raw.out -o=coverage.out
 
 .PHONY: test
 test: pkg/collector/testdata/sys/.unpacked pkg/collector/testdata/proc/.unpacked bpf

cmd/ceems_api_server/main_test.go

@@ -23,15 +23,6 @@ func TestBatchjobStatsExecutable(t *testing.T) {
 		t.Skipf("ceems_api_server binary not available, try to run `make build` first: %s", err)
 	}
 
-	tmpDir := t.TempDir()
-	tmpSacctPath := tmpDir + "/sacct"
-
-	sacctPath, err := filepath.Abs("../../pkg/api/testdata/sacct")
-	require.NoError(t, err)
-
-	err = os.Link(sacctPath, tmpSacctPath)
-	require.NoError(t, err)
-
 	usagestats := exec.CommandContext(
 		t.Context(),
 		binary,

pkg/collector/ipmi_test.go

@@ -5,7 +5,6 @@ package collector
 
 import (
 	"errors"
-	"fmt"
 	"os"
 	"path/filepath"
 	"testing"
@@ -238,15 +237,12 @@ func TestIpmiClientFinder(t *testing.T) {
 		},
 	}
 
-	// Get PATH
-	basePath := os.Getenv("PATH")
-
 	for _, test := range tests {
 		ipmiClientPath, err := filepath.Abs(filepath.Join("testdata/ipmi", test.path))
 		require.NoError(t, err)
 
 		// Set path
-		t.Setenv("PATH", fmt.Sprintf("%s:%s", ipmiClientPath, basePath))
+		t.Setenv("PATH", ipmiClientPath)
 
 		ipmiClientSlice, err := findIPMICmd()
 		require.NoError(t, err, test.name)
@@ -259,7 +255,7 @@ func TestCachedPowerReadings(t *testing.T) {
 	tmpIPMIPath := tmpDir + "/ipmiutil"
 
 	// Set path
-	t.Setenv("PATH", fmt.Sprintf("%s:%s", tmpDir, os.Getenv("PATH")))
+	t.Setenv("PATH", tmpDir)
 
 	// Expected values
 	expected := map[string]float64{"dcmi_avg": 49, "dcmi_current": 304, "dcmi_max": 304, "dcmi_min": 6}

scripts/e2e-test.sh

@@ -570,7 +570,7 @@ then
 
   elif [ "${scenario}" = "exporter-cgroups-v2-nvidia-ipmiutil" ] 
   then
-      REDFISH_HOST=localhost REDFISH_PORT=5000 PATH="${PWD}/pkg/collector/testdata/ipmi/ipmiutils:${PATH}" ./bin/ceems_exporter \
+      REDFISH_HOST=localhost REDFISH_PORT=5000 ./bin/ceems_exporter \
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
@@ -584,6 +584,7 @@ then
         --collector.empty-hostname-label \
         --collector.ipmi \
         --collector.ipmi.test-mode \
+        --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/ipmiutils/ipmiutil" \
         --collector.redfish \
         --collector.redfish.config.file="pkg/collector/testdata/redfish/config.yml" \
         --collector.redfish.config.file.expand-env-vars \
@@ -596,7 +597,7 @@ then
 
   elif [ "${scenario}" = "exporter-cgroups-v2-nvidia-gpu-reordering" ] 
   then
-      PATH="${PWD}/pkg/collector/testdata/ipmi/ipmiutils:${PATH}" ./bin/ceems_exporter \
+      ./bin/ceems_exporter \
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
@@ -610,6 +611,7 @@ then
         --collector.empty-hostname-label \
         --collector.ipmi \
         --collector.ipmi.test-mode \
+        --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/ipmiutils/ipmiutil" \
         --collector.cray_pm_counters \
         --collector.rapl \
         --web.listen-address "127.0.0.1:${port}" \
@@ -618,7 +620,7 @@ then
 
   elif [ "${scenario}" = "exporter-cgroups-v2-amd-ipmitool" ] 
   then
-      REDFISH_HOST=localhost REDFISH_PORT=5000 PATH="${PWD}/pkg/collector/testdata/ipmi/openipmi:${PATH}" ./bin/ceems_exporter \
+      REDFISH_HOST=localhost REDFISH_PORT=5000 ./bin/ceems_exporter \
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
@@ -630,6 +632,7 @@ then
         --collector.hwmon \
         --collector.ipmi \
         --collector.ipmi.test-mode \
+        --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/openipmi/ipmitool" \
         --collector.redfish \
         --collector.redfish.config.file="pkg/collector/testdata/redfish/config.yml" \
         --collector.redfish.config.file.expand-env-vars \
@@ -640,7 +643,7 @@ then
 
   elif [ "${scenario}" = "exporter-cgroups-v2-nogpu" ] 
   then
-      PATH="${PWD}/pkg/collector/testdata/ipmi/capmc:${PATH}" ./bin/ceems_exporter \
+      ./bin/ceems_exporter \
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
@@ -650,6 +653,7 @@ then
         --collector.empty-hostname-label \
         --collector.ipmi \
         --collector.ipmi.test-mode \
+        --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/capmc/capmc" \
         --collector.infiniband \
         --collector.rapl \
         --collector.emissions \