Fix config for 3x rtt

Author: LauJosefsen

README.md

@@ -4,7 +4,7 @@
 
 Per default in most PHP applications, a new curl handle is created for each outgoing request, which will require a new TCP connection to be established, and a TLS handshake to be performed if the request is made over HTTPS.
 
-The TLS handshake can be a big performance penalty for applications that strive for low latency, as it requires 2 round trips between the client and the server. This can easily reach 100ms and more depending on your round trip latency to the server.
+The TLS handshake can be a big performance penalty for applications that strive for low latency, as it requires 2 round trips between the client and the server for the TLS handshake, and one round trip for the TCP connection. This can easily reach 100ms and more depending on your round trip latency to the server.
 
 # Solution
 
@@ -26,23 +26,26 @@ composer require cego/curl-handle-reuse-laravel-octane
 Feel free to open issues or pull requests if you have any suggestions or improvements. Remember to run php-cs-fixer, unittests and phpstan before opening a pull request.
 
 # Performance
-You can expect to reduce the latency of outgoing requests by 2 times the latency roundtrip. The speedup factor will depend on the latency of the server you are connecting to, compared to the execution time of the endpoint you are calling.
+You can expect to reduce the latency of outgoing requests by 3 times the latency roundtrip. The speedup factor will depend on the latency of the server you are connecting to, compared to the execution time of the endpoint you are calling.
 
 For example if you have a server with a 100ms roundtrip latency, and the endpoint takes 100ms to execute, then you are likely to see a speedup from 400ms to 200ms.
 
 ## Benchmarks
-See tests/Benchmark for a simple PHPBench setup that pings github.com/robots.txt 50 times with and without the package. With the package, a prewarmed curl handle is used.
+See tests/Benchmark for a simple PHPBench setup that pings github.com/robots.txt 50 times with and without the package. With the package, a prewarmed curl handle is used. The round-trip latency was measured to approximately 19.5ms.
 
 ```
-+-----------------+------------------------------------+----------+----------+----------+----------+--------+---------+
-| benchmark       | subject                            | memory   | min      | max      | mode     | rstdev | stdev   |
-+-----------------+------------------------------------+----------+----------+----------+----------+--------+---------+
-| HttpReusedBench | benchHttpWithReusedCurlHandle ()   | 16.448mb | 25.870ms | 25.870ms | 25.870ms | ±0.00% | 0.000μs |
-| HttpBench       | benchHttpWithoutServiceProvider () | 16.411mb | 76.186ms | 76.186ms | 76.186ms | ±0.00% | 0.000μs |
-+-----------------+------------------------------------+----------+----------+----------+----------+--------+---------+
-
++---------------------------+----------------------------------------------------+----------+-----------+-----------+-----------+--------+---------+
+| benchmark                 | subject                                            | memory   | min       | max       | mode      | rstdev | stdev   |
++---------------------------+----------------------------------------------------+----------+-----------+-----------+-----------+--------+---------+
+| HttpReusedCurlHandleBench | benchHttpWithoutReusedCurlHandle ()                | 16.581mb | 77.222ms  | 77.222ms  | 77.222ms  | ±0.00% | 0.000μs |
+| HttpReusedCurlHandleBench | benchHttpWithReusedCurlHandle ()                   | 16.607mb | 20.812ms  | 20.812ms  | 20.812ms  | ±0.00% | 0.000μs |
+| HttpReusedCurlHandleBench | benchHttpWithReusedCurlHandleMultipleOrigins ()    | 18.103mb | 47.237ms  | 47.237ms  | 47.237ms  | ±0.00% | 0.000μs |
+| HttpReusedCurlHandleBench | benchHttpWithoutReusedCurlHandleMultipleOrigins () | 18.078mb | 181.377ms | 181.377ms | 181.377ms | ±0.00% | 0.000μs |
++---------------------------+----------------------------------------------------+----------+-----------+-----------+-----------+--------+---------+
 ```
 
+As can be seen, the benchmark of querying github.com/robots.txt 50 times is reduced from 77.222ms to 20.812ms, which is approximately 3x roundtrip latency of 19.5ms. (it would be equivalent to roundtrip latency of 18.8ms)
+
 
 ## See also
 Aaron Francis has covered this topic in a video on his YouTube channel, where he explains the performance benefits of reusing curl handles in Laravel Octane. You can watch the video here:

src/CurlHandleReuseLaravelOctaneServiceProvider.php

@@ -11,7 +11,7 @@ public function register(): void
     {
         $this->mergeConfigFrom(__DIR__ . '/../config/curl-handle-reuse-laravel-octane.php', 'curl-handle-reuse-laravel-octane');
         $this->app->instance(ReusedCurlHandle::class, new ReusedCurlHandle(
-            config('curl-handle-reuse-laravel-octane.max_handles', 1000),
+            config('curl-handle-reuse-laravel-octane.max_handles'),
         ));
         $this->app->bind(Factory::class, ReusedCurlHandleFactory::class);
     }

tests/Benchmark/HttpReusedCurlHandleBench.php

@@ -35,13 +35,13 @@ public function prewarmWithServiceProvider(): void
     #[BeforeMethods('prewarm'), Revs(50)]
     public function benchHttpWithoutReusedCurlHandle()
     {
-        Http::get('https://ventraip.com.au/robots.txt');
+        Http::get('https://github.com/robots.txt');
     }
 
     #[BeforeMethods('prewarmWithServiceProvider'), Revs(50)]
     public function benchHttpWithReusedCurlHandle()
     {
-        Http::get('https://ventraip.com.au/robots.txt');
+        Http::get('https://github.com/robots.txt');
     }
 
     #[BeforeMethods('prewarmWithServiceProvider'), Revs(50)]