-
-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metadata] section of setup.cfg does nothing #466
Comments
It's for wheel. It needs it to install importlib and ordereddict on Python 2.6 |
@bmbouter python setup.py bdist_wheel |
I don't know much about wheel so far, but the At first the wheel would not work on Python 2.6, as the wheel was generated using The solution is not very satisfactory since it means we need to specify the dependencies in yet another location. We have I think there was a PEP for a static metadata format for dependencies, which maybe this is based on or inspired from, so it would be great if there was a single location for this info. |
Wheels do support conditional dependencies, we could have a fix like this https://bitbucket.org/pytest-dev/pytest/pull-request/269/add-support-for-building-proper-wheels/diff I'll take a stab at this in few days, if no one wants to do it. |
I've been looking over how the 3.0 release stream of kombu handles its dependencies, and I can't tell what the purpose of the metadata section of setup.cfg is. It has already been removed from the 4.0-dev and master branches. I believe it's related to wheel packaging, and potentially this 3.0.19 release note.
If I modify setup.cfg to declare a package that doesn't exist I expect that when I install it it would fail saying it can't resolve a dependency. Instead it happily installs through all methods I know of including running these in the modified checkout folder:
This is true both with and without
d2to1
installed in pip. What is the purpose of this[metadata]
section? Should it still be here?The text was updated successfully, but these errors were encountered: