Skip to content

Commit 74c23fa

Browse files
author
Tobias Knöschke
committed
Generator: change to cppassist::error()
1 parent 59e52b1 commit 74c23fa

File tree

3 files changed

+42
-38
lines changed

3 files changed

+42
-38
lines changed

scripts/generate.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def buildCPPImplementation(func, enums):
381381
paramCases.append(caseCode)
382382

383383
if neededVariantChecks:
384-
paramCases.append(" std::cerr << \"Invalid parameters for " + funcName + "\" << std::endl;\n return;")
384+
paramCases.append(" cppassist::error(\"glkernel-JSInterface\") << \"Invalid parameters for " + funcName + "\";\n return;")
385385

386386
paramCasesCode = '\n\n'.join(paramCases)
387387

@@ -394,7 +394,7 @@ def buildCPPImplementation(func, enums):
394394
{{
395395
{earlyConv}{cases}
396396
397-
std::cerr << "Invalid kernel object for {funcName}" << std::endl;
397+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for {funcName}";
398398
}}""".format(funcName = funcName, paramList = paramList, earlyConv = earlyConversions, cases = kernelCasesCode)
399399

400400
return fullCode

scripts/templates/JSInterface.cpp.template

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
#include <cppexpose/variant/Variant.h>
1616
#include <cppexpose/scripting/ScriptContext.h>
1717

18+
#include <cppassist/logging/logging.h>
19+
1820

1921
JSInterface::JSInterface()
2022
: Object("_glkernel")

source/tools/glkernel-cli/JSInterface.cpp

+38-36
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
#include <cppexpose/variant/Variant.h>
2323
#include <cppexpose/scripting/ScriptContext.h>
2424

25+
#include <cppassist/logging/logging.h>
26+
2527

2628
JSInterface::JSInterface()
2729
: Object("_glkernel")
@@ -86,7 +88,7 @@ void JSInterface::noise_uniform(cppexpose::Object* obj, const cppexpose::Variant
8688
return;
8789
}
8890

89-
std::cerr << "Invalid parameters for noise_uniform" << std::endl;
91+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_uniform";
9092
return;
9193
}
9294

@@ -110,7 +112,7 @@ void JSInterface::noise_uniform(cppexpose::Object* obj, const cppexpose::Variant
110112
return;
111113
}
112114

113-
std::cerr << "Invalid parameters for noise_uniform" << std::endl;
115+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_uniform";
114116
return;
115117
}
116118

@@ -134,7 +136,7 @@ void JSInterface::noise_uniform(cppexpose::Object* obj, const cppexpose::Variant
134136
return;
135137
}
136138

137-
std::cerr << "Invalid parameters for noise_uniform" << std::endl;
139+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_uniform";
138140
return;
139141
}
140142

@@ -158,11 +160,11 @@ void JSInterface::noise_uniform(cppexpose::Object* obj, const cppexpose::Variant
158160
return;
159161
}
160162

161-
std::cerr << "Invalid parameters for noise_uniform" << std::endl;
163+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_uniform";
162164
return;
163165
}
164166

165-
std::cerr << "Invalid kernel object for noise_uniform" << std::endl;
167+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for noise_uniform";
166168
}
167169

168170

@@ -179,7 +181,7 @@ void JSInterface::noise_normal(cppexpose::Object* obj, const cppexpose::Variant&
179181
return;
180182
}
181183

182-
std::cerr << "Invalid parameters for noise_normal" << std::endl;
184+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_normal";
183185
return;
184186
}
185187

@@ -203,7 +205,7 @@ void JSInterface::noise_normal(cppexpose::Object* obj, const cppexpose::Variant&
203205
return;
204206
}
205207

206-
std::cerr << "Invalid parameters for noise_normal" << std::endl;
208+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_normal";
207209
return;
208210
}
209211

@@ -227,7 +229,7 @@ void JSInterface::noise_normal(cppexpose::Object* obj, const cppexpose::Variant&
227229
return;
228230
}
229231

230-
std::cerr << "Invalid parameters for noise_normal" << std::endl;
232+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_normal";
231233
return;
232234
}
233235

@@ -251,11 +253,11 @@ void JSInterface::noise_normal(cppexpose::Object* obj, const cppexpose::Variant&
251253
return;
252254
}
253255

254-
std::cerr << "Invalid parameters for noise_normal" << std::endl;
256+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for noise_normal";
255257
return;
256258
}
257259

258-
std::cerr << "Invalid kernel object for noise_normal" << std::endl;
260+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for noise_normal";
259261
}
260262

261263

@@ -270,7 +272,7 @@ void JSInterface::noise_gradient(cppexpose::Object* obj, int noise_type, int oct
270272
return;
271273
}
272274

273-
std::cerr << "Invalid kernel object for noise_gradient" << std::endl;
275+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for noise_gradient";
274276
}
275277

276278

@@ -282,7 +284,7 @@ void JSInterface::sample_poisson_square(cppexpose::Object* obj, unsigned int num
282284
return;
283285
}
284286

285-
std::cerr << "Invalid kernel object for sample_poisson_square" << std::endl;
287+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_poisson_square";
286288
}
287289

288290

@@ -294,7 +296,7 @@ void JSInterface::sample_poisson_square1(cppexpose::Object* obj, float min_dist,
294296
return;
295297
}
296298

297-
std::cerr << "Invalid kernel object for sample_poisson_square1" << std::endl;
299+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_poisson_square1";
298300
}
299301

300302

@@ -318,7 +320,7 @@ void JSInterface::sample_stratified(cppexpose::Object* obj)
318320
return;
319321
}
320322

321-
std::cerr << "Invalid kernel object for sample_stratified" << std::endl;
323+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_stratified";
322324
}
323325

324326

@@ -330,7 +332,7 @@ void JSInterface::sample_hammersley(cppexpose::Object* obj)
330332
return;
331333
}
332334

333-
std::cerr << "Invalid kernel object for sample_hammersley" << std::endl;
335+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_hammersley";
334336
}
335337

336338

@@ -342,7 +344,7 @@ void JSInterface::sample_halton(cppexpose::Object* obj, unsigned int base1, unsi
342344
return;
343345
}
344346

345-
std::cerr << "Invalid kernel object for sample_halton" << std::endl;
347+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_halton";
346348
}
347349

348350

@@ -356,7 +358,7 @@ void JSInterface::sample_hammersley_sphere(cppexpose::Object* obj, int type)
356358
return;
357359
}
358360

359-
std::cerr << "Invalid kernel object for sample_hammersley_sphere" << std::endl;
361+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_hammersley_sphere";
360362
}
361363

362364

@@ -370,7 +372,7 @@ void JSInterface::sample_halton_sphere(cppexpose::Object* obj, unsigned int base
370372
return;
371373
}
372374

373-
std::cerr << "Invalid kernel object for sample_halton_sphere" << std::endl;
375+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_halton_sphere";
374376
}
375377

376378

@@ -388,7 +390,7 @@ void JSInterface::sample_best_candidate(cppexpose::Object* obj, unsigned int num
388390
return;
389391
}
390392

391-
std::cerr << "Invalid kernel object for sample_best_candidate" << std::endl;
393+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_best_candidate";
392394
}
393395

394396

@@ -400,7 +402,7 @@ void JSInterface::sample_n_rooks(cppexpose::Object* obj)
400402
return;
401403
}
402404

403-
std::cerr << "Invalid kernel object for sample_n_rooks" << std::endl;
405+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_n_rooks";
404406
}
405407

406408

@@ -412,7 +414,7 @@ void JSInterface::sample_multi_jittered(cppexpose::Object* obj, bool correlated)
412414
return;
413415
}
414416

415-
std::cerr << "Invalid kernel object for sample_multi_jittered" << std::endl;
417+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_multi_jittered";
416418
}
417419

418420

@@ -424,7 +426,7 @@ void JSInterface::sample_golden_point_set(cppexpose::Object* obj)
424426
return;
425427
}
426428

427-
std::cerr << "Invalid kernel object for sample_golden_point_set" << std::endl;
429+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sample_golden_point_set";
428430
}
429431

430432

@@ -454,7 +456,7 @@ void JSInterface::scale_range(cppexpose::Object* obj, float rangeToLower, float
454456
return;
455457
}
456458

457-
std::cerr << "Invalid kernel object for scale_range" << std::endl;
459+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for scale_range";
458460
}
459461

460462

@@ -471,7 +473,7 @@ void JSInterface::sequence_uniform(cppexpose::Object* obj, const cppexpose::Vari
471473
return;
472474
}
473475

474-
std::cerr << "Invalid parameters for sequence_uniform" << std::endl;
476+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sequence_uniform";
475477
return;
476478
}
477479

@@ -495,7 +497,7 @@ void JSInterface::sequence_uniform(cppexpose::Object* obj, const cppexpose::Vari
495497
return;
496498
}
497499

498-
std::cerr << "Invalid parameters for sequence_uniform" << std::endl;
500+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sequence_uniform";
499501
return;
500502
}
501503

@@ -519,7 +521,7 @@ void JSInterface::sequence_uniform(cppexpose::Object* obj, const cppexpose::Vari
519521
return;
520522
}
521523

522-
std::cerr << "Invalid parameters for sequence_uniform" << std::endl;
524+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sequence_uniform";
523525
return;
524526
}
525527

@@ -543,11 +545,11 @@ void JSInterface::sequence_uniform(cppexpose::Object* obj, const cppexpose::Vari
543545
return;
544546
}
545547

546-
std::cerr << "Invalid parameters for sequence_uniform" << std::endl;
548+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sequence_uniform";
547549
return;
548550
}
549551

550-
std::cerr << "Invalid kernel object for sequence_uniform" << std::endl;
552+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sequence_uniform";
551553
}
552554

553555

@@ -577,7 +579,7 @@ void JSInterface::shuffle_bucket_permutate(cppexpose::Object* obj, glm::uint16 s
577579
return;
578580
}
579581

580-
std::cerr << "Invalid kernel object for shuffle_bucket_permutate" << std::endl;
582+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for shuffle_bucket_permutate";
581583
}
582584

583585

@@ -607,7 +609,7 @@ void JSInterface::shuffle_bayer(cppexpose::Object* obj)
607609
return;
608610
}
609611

610-
std::cerr << "Invalid kernel object for shuffle_bayer" << std::endl;
612+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for shuffle_bayer";
611613
}
612614

613615

@@ -637,7 +639,7 @@ void JSInterface::shuffle_random(cppexpose::Object* obj, size_t start)
637639
return;
638640
}
639641

640-
std::cerr << "Invalid kernel object for shuffle_random" << std::endl;
642+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for shuffle_random";
641643
}
642644

643645

@@ -653,7 +655,7 @@ void JSInterface::sort_distance(cppexpose::Object* obj, const cppexpose::Variant
653655
return;
654656
}
655657

656-
std::cerr << "Invalid parameters for sort_distance" << std::endl;
658+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sort_distance";
657659
return;
658660
}
659661

@@ -667,7 +669,7 @@ void JSInterface::sort_distance(cppexpose::Object* obj, const cppexpose::Variant
667669
return;
668670
}
669671

670-
std::cerr << "Invalid parameters for sort_distance" << std::endl;
672+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sort_distance";
671673
return;
672674
}
673675

@@ -681,7 +683,7 @@ void JSInterface::sort_distance(cppexpose::Object* obj, const cppexpose::Variant
681683
return;
682684
}
683685

684-
std::cerr << "Invalid parameters for sort_distance" << std::endl;
686+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sort_distance";
685687
return;
686688
}
687689

@@ -695,9 +697,9 @@ void JSInterface::sort_distance(cppexpose::Object* obj, const cppexpose::Variant
695697
return;
696698
}
697699

698-
std::cerr << "Invalid parameters for sort_distance" << std::endl;
700+
cppassist::error("glkernel-JSInterface") << "Invalid parameters for sort_distance";
699701
return;
700702
}
701703

702-
std::cerr << "Invalid kernel object for sort_distance" << std::endl;
704+
cppassist::error("glkernel-JSInterface") << "Invalid kernel object for sort_distance";
703705
}

0 commit comments

Comments
 (0)