Skip to content

Commit efee018

Browse files
committed
Merge branch 'master' of github.com:cginternals/glkernel
2 parents 659a453 + db2e5b4 commit efee018

File tree

7 files changed

+30
-16
lines changed

7 files changed

+30
-16
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,5 @@ build/
3939

4040
# build directories
4141
build
42+
*-build*
4243
build-*

configure

+21-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/bin/bash
22

33
# Default options
4+
45
BUILD_DIR="build"
56
CMAKE_GENERATOR="Unix Makefiles"
67
BUILD_TYPE="Release"
@@ -99,19 +100,33 @@ do
99100
fi
100101
done
101102

103+
if [ "$CMAKE_GENERATOR_OVERRIDE" != "" ]
104+
then
105+
echo "Override CMAKE_GENERATOR to $CMAKE_GENERATOR_OVERRIDE"
106+
CMAKE_GENERATOR="$CMAKE_GENERATOR_OVERRIDE"
107+
fi
108+
109+
if [ -n "$BUILD_DIR_PREFIX" ]; then
110+
BUILD_DIR="${BUILD_DIR_PREFIX}-${BUILD_DIR}"
111+
fi
112+
102113
# Configure build
103-
echo "Configuring ..."
114+
echo "Configuring in \"$BUILD_DIR\""
104115
echo ""
105116

106117
# Create build directory
107-
if [ ! -d "./$BUILD_DIR" ]
118+
if [ ! -d "$BUILD_DIR" ]
108119
then
109-
mkdir $BUILD_DIR
120+
mkdir -p "$BUILD_DIR"
110121
fi
111122

112123
# Configure project
113-
cd $BUILD_DIR
114-
cmake -G "$CMAKE_GENERATOR" "-DCMAKE_BUILD_TYPE=$BUILD_TYPE" $CMAKE_OPTIONS ..
124+
125+
PREVIOUS_DIR=$(pwd)
126+
127+
pushd $BUILD_DIR
128+
echo cmake -G "$CMAKE_GENERATOR" "-DCMAKE_BUILD_TYPE=$BUILD_TYPE" $CMAKE_OPTIONS "$PREVIOUS_DIR"
129+
cmake -G "$CMAKE_GENERATOR" "-DCMAKE_BUILD_TYPE=$BUILD_TYPE" $CMAKE_OPTIONS "$PREVIOUS_DIR"
115130
if [ $? == 0 ]
116131
then
117132
echo ""
@@ -122,5 +137,4 @@ else
122137
echo ""
123138
echo "Configuration failed.";
124139
fi
125-
126-
cd ..
140+
popd

source/glkernel/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# External dependencies
44
#
55

6-
find_package(glm REQUIRED)
6+
find_package(glm CONFIG REQUIRED)
77

88

99
#

source/glkernel/include/glkernel/noise.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ void uniform(tkernel<V> & kernel, const typename V::value_type range_min, const
310310
kernel.template for_each<uniform_operator<typename V::value_type>>(range_min, range_max);
311311
}
312312

313-
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
313+
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
314314
void uniform(tkernel<V> & kernel, const V & range_min, const V & range_max)
315315
{
316316
kernel.template for_each<uniform_operator<typename V::value_type>>(range_min, range_max);
@@ -366,13 +366,13 @@ void normal(tkernel<T> & kernel, const T mean, const T stddev)
366366
kernel.template for_each<normal_operator<T>>(mean, stddev);
367367
}
368368

369-
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
369+
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
370370
void normal(tkernel<V> & kernel, const typename V::value_type mean, const typename V::value_type stddev)
371371
{
372372
kernel.template for_each<normal_operator<typename V::value_type>>(mean, stddev);
373373
}
374374

375-
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
375+
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
376376
void normal(tkernel<V> & kernel, const V & mean, const V & stddev)
377377
{
378378
kernel.template for_each<normal_operator<typename V::value_type>>(mean, stddev);

source/glkernel/include/glkernel/scale.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ void range(tkernel<T> & kernel, T rangeToLower, T rangeToUpper, T rangeFromLower
6161
kernel.template for_each_element<range_operator<T>>(rangeToLower, rangeToUpper, rangeFromLower, rangeFromUpper);
6262
}
6363

64-
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
64+
template <typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
6565
void range(tkernel<V> & kernel, typename V::value_type rangeToLower, typename V::value_type rangeToUpper, typename V::value_type rangeFromLower, typename V::value_type rangeFromUpper)
6666
{
6767
kernel.template for_each_element<range_operator<typename V::value_type>>(rangeToLower, rangeToUpper, rangeFromLower, rangeFromUpper);

source/glkernel/include/glkernel/sequence.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ void uniform(tkernel<T> & kernel, const T range_min, const T range_max)
6666
kernel.template for_each<uniform_operator<T>>(range_min, range_max);
6767
}
6868

69-
template<typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
69+
template<typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
7070
void uniform(tkernel<V> & kernel, const typename V::value_type range_min, const typename V::value_type range_max)
7171
{
7272
kernel.template for_each<uniform_operator<typename V::value_type>>(range_min, range_max);
7373
}
7474

75-
template<typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type * = nullptr>
75+
template<typename V, typename std::enable_if<std::is_floating_point<typename V::value_type>::value>::type *>
7676
void uniform(tkernel<V> & kernel, const V & range_min, const V & range_max)
7777
{
7878
kernel.template for_each<uniform_operator<typename V::value_type>>(range_min, range_max);

source/tests/glkernel-test/CMakeLists.txt

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
find_package(${META_PROJECT_NAME} REQUIRED HINTS "${CMAKE_CURRENT_SOURCE_DIR}/../../../")
77

8-
find_package(glm REQUIRED)
8+
find_package(glm CONFIG REQUIRED)
99
find_package(OpenMP QUIET)
1010

1111
#
@@ -71,7 +71,6 @@ set_target_properties(${target}
7171
target_include_directories(${target}
7272
PRIVATE
7373
${DEFAULT_INCLUDE_DIRECTORIES}
74-
glm::glm
7574
${PROJECT_BINARY_DIR}/source/include
7675
)
7776

0 commit comments

Comments
 (0)