You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since integrating #270, embedding a webgl-operate based canvas inside a cross-origin iframe that is not explicitly trusted via sandbox="allow-top-navigation" leads to a runtime TypeError, independent of whether the GET parameters are actually set for masquerading or not.
Since integrating #270, embedding a webgl-operate based canvas inside a cross-origin iframe that is not explicitly trusted via
sandbox="allow-top-navigation"
leads to a runtime TypeError, independent of whether the GET parameters are actually set for masquerading or not.View this CodeSandbox for a live example of the runtime error: https://codesandbox.io/s/sleepy-wood-wrxnl
Changing the webgl-operate version from 0.7.5 to 0.7.1 in the CodeSandbox makes the error disappear:
https://codesandbox.io/s/vigorous-mclaren-4s7p2
Thus, we should wrap the two
window.top.location
accesses introduced by #270 with corresponding try/catch blocks:webgl-operate/source/auxiliaries.ts
Line 308 in 282d4c3
webgl-operate/source/auxiliaries.ts
Lines 321 to 322 in 282d4c3
The text was updated successfully, but these errors were encountered: