Skip to content

Commit b427412

Browse files
committed
feat : 깃헙 액션 수정
1 parent acd5c3c commit b427412

File tree

4 files changed

+28
-10
lines changed

4 files changed

+28
-10
lines changed

Diff for: .github/workflows/firebase-hosting-merge.yml

+10-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,18 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@v4
14-
- run: npm install && npm run build
14+
- run: npm install
15+
- run: npm run build
16+
env:
17+
VITE_FIREBASE_API_KEY: ${{ secrets.VITE_FIREBASE_API_KEY }}
18+
VITE_FIREBASE_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_AUTH_DOMAIN }}
19+
VITE_FIREBASE_PROJECT_ID: ${{ secrets.VITE_FIREBASE_PROJECT_ID }}
20+
VITE_FIREBASE_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_STORAGE_BUCKET }}
21+
VITE_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_MESSAGING_SENDER_ID }}
22+
VITE_FIREBASE_APP_ID: ${{ secrets.VITE_FIREBASE_APP_ID }}
1523
- uses: FirebaseExtended/action-hosting-deploy@v0
1624
with:
1725
repoToken: ${{ secrets.GITHUB_TOKEN }}
1826
firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_REACT_TASK_APP_45F27 }}
1927
channelId: live
20-
projectId: react-task-app-45f27
28+
projectId: ${{ secrets.VITE_FIREBASE_PROJECT_ID }}

Diff for: .github/workflows/firebase-hosting-pull-request.yml

+10-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,17 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@v4
16-
- run: npm install && npm run build
16+
- run: npm install
17+
- run: npm run build
18+
env:
19+
VITE_FIREBASE_API_KEY: ${{ secrets.VITE_FIREBASE_API_KEY }}
20+
VITE_FIREBASE_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_AUTH_DOMAIN }}
21+
VITE_FIREBASE_PROJECT_ID: ${{ secrets.VITE_FIREBASE_PROJECT_ID }}
22+
VITE_FIREBASE_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_STORAGE_BUCKET }}
23+
VITE_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_MESSAGING_SENDER_ID }}
24+
VITE_FIREBASE_APP_ID: ${{ secrets.VITE_FIREBASE_APP_ID }}
1725
- uses: FirebaseExtended/action-hosting-deploy@v0
1826
with:
1927
repoToken: ${{ secrets.GITHUB_TOKEN }}
2028
firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_REACT_TASK_APP_45F27 }}
21-
projectId: react-task-app-45f27
29+
projectId: ${{ secrets.VITE_FIREBASE_PROJECT_ID }}

Diff for: .gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ dist
1212
dist-ssr
1313
*.local
1414

15+
.env
16+
1517
# Editor directories and files
1618
.vscode/*
1719
!.vscode/extensions.json

Diff for: src/firebase.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import { getAuth, GoogleAuthProvider } from "firebase/auth";
66

77
// Your web app's Firebase configuration
88
const firebaseConfig = {
9-
apiKey: "AIzaSyBrEBKZDn6MBcMfyexRNfRDcn0fT0pxj1Y",
10-
authDomain: "react-task-app-45f27.firebaseapp.com",
11-
projectId: "react-task-app-45f27",
12-
storageBucket: "react-task-app-45f27.firebasestorage.app",
13-
messagingSenderId: "1076619980718",
14-
appId: "1:1076619980718:web:8951aca74daaa862a9e23f",
9+
apiKey: import.meta.env.VITE_FIREBASE_API_KEY,
10+
authDomain: import.meta.env.VITE_FIREBASE_AUTH_DOMAIN,
11+
projectId: import.meta.env.VITE_FIREBASE_PROJECT_ID,
12+
storageBucket: import.meta.env.VITE_FIREBASE_STORAGE_BUCKET,
13+
messagingSenderId: import.meta.env.VITE_FIREBASE_MESSAGING_SENDER_ID,
14+
appId: import.meta.env.VITE_FIREBASE_APP_ID,
1515
};
1616

1717
// Initialize Firebase

0 commit comments

Comments
 (0)