errors: Add LedgerError to bitcoincore_rpc::Error converter.

Author: ceyhunsen

src/client/rpc_api.rs

@@ -44,13 +44,9 @@ impl RpcApi for Client {
     ) -> bitcoincore_rpc::Result<bitcoin::Txid> {
         let tx: Transaction = encode::deserialize_hex(&tx.raw_hex()).unwrap();
 
-        if let Err(e) = self.ledger.check_transaction(tx.clone()) {
-            return Err(bitcoincore_rpc::Error::Io(std::io::Error::other(format!(
-                "{e}"
-            ))));
-        }
+        self.ledger.check_transaction(tx.clone())?;
 
-        self.ledger.add_transaction_unconditionally(tx.clone());
+        self.ledger.add_transaction_unconditionally(tx.clone())?;
 
         Ok(tx.compute_txid())
     }
@@ -186,7 +182,7 @@ impl RpcApi for Client {
             output: vec![txout],
         };
 
-        self.ledger.add_transaction_unconditionally(tx.clone());
+        self.ledger.add_transaction_unconditionally(tx.clone())?;
 
         for output in tx.output {
             self.ledger.add_utxo(output);

src/ledger/errors.rs

@@ -10,3 +10,9 @@ pub enum LedgerError {
     #[error("Database returned an error: {0}")]
     Database(anyhow::Error),
 }
+
+impl From<LedgerError> for bitcoincore_rpc::Error {
+    fn from(error: LedgerError) -> Self {
+        bitcoincore_rpc::Error::ReturnedError(error.to_string())
+    }
+}

src/ledger/mod.rs

@@ -33,6 +33,11 @@ pub struct Ledger {
 
 impl Ledger {
     /// Creates a new empty ledger.
+    ///
+    /// # Panics
+    ///
+    /// If database connection cannot be established in bitcoin-simulator, it
+    /// will panic.
     pub fn new() -> Self {
         Self {
             database: Arc::new(Mutex::new(Database::connect_temporary_database().unwrap())),

src/ledger/transactions.rs

@@ -15,14 +15,22 @@ impl Ledger {
     }
 
     /// Adds transaction to current block, without checking anything.
-    pub fn add_transaction_unconditionally(&self, transaction: Transaction) {
-        self.database
+    pub fn add_transaction_unconditionally(
+        &self,
+        transaction: Transaction,
+    ) -> Result<(), LedgerError> {
+        if let Err(e) = self
+            .database
             .lock()
             .unwrap()
             .insert_transaction_unconditionally(&transaction)
-            .unwrap();
+        {
+            return Err(LedgerError::Database(e));
+        };
 
         add_item!(self.transactions, transaction);
+
+        Ok(())
     }
     /// Returns user's list of transactions.
     pub fn get_transaction(&self, txid: Txid) -> Transaction {