fix(combobox): open-change invoked twice

segunadebayo · segunadebayo · commit 7ede4dbd0634 · 2025-03-21T14:34:36.000Z
diff --git a/.changeset/olive-dodos-decide.md b/.changeset/olive-dodos-decide.md
@@ -0,0 +1,5 @@
+---
+"@zag-js/combobox": patch
+---
+
+Fix issue where `onOpenChange` with the same `open` value
diff --git a/packages/machines/combobox/src/combobox.machine.ts b/packages/machines/combobox/src/combobox.machine.ts
@@ -400,11 +400,11 @@ export const machine = createMachine<ComboboxSchema>({
           {
             guard: "autoComplete",
             target: "suggesting",
-            actions: ["setInputValue", "invokeOnOpen"],
+            actions: ["setInputValue"],
           },
           {
             target: "suggesting",
-            actions: ["clearHighlightedItem", "setInputValue", "invokeOnOpen"],
+            actions: ["clearHighlightedItem", "setInputValue"],
           },
         ],
         "ITEM.POINTER_MOVE": {

Original file line number	Diff line number	Diff line change
`@@ -400,11 +400,11 @@ export const machine = createMachine<ComboboxSchema>({`
`400`	`400`	`{`
`401`	`401`	`guard: "autoComplete",`
`402`	`402`	`target: "suggesting",`
`403`		`- actions: ["setInputValue", "invokeOnOpen"],`
	`403`	`+ actions: ["setInputValue"],`
`404`	`404`	`},`
`405`	`405`	`{`
`406`	`406`	`target: "suggesting",`
`407`		`- actions: ["clearHighlightedItem", "setInputValue", "invokeOnOpen"],`
	`407`	`+ actions: ["clearHighlightedItem", "setInputValue"],`
`408`	`408`	`},`
`409`	`409`	`],`
`410`	`410`	`"ITEM.POINTER_MOVE": {`