Skip to content

Commit 15edaf1

Browse files
committed
remove the LCI1 backend
1 parent e9a6c9d commit 15edaf1

8 files changed

+1
-282
lines changed

.github/workflows/ci-lci1.yml

-52
This file was deleted.

CMakeLists.txt

-7
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,6 @@ set(RECONVERSE_AUTOFETCH_LCI2_TAG
3333
"85dc99f3b32cfc8b3b4b0e0590ee445282964b57"
3434
CACHE STRING "The tag to fetch for LCIv2") # master branch as of 2025-04-17
3535

36-
option(RECONVERSE_TRY_ENABLE_COMM_LCI1 "whether to enable the LCIv1 backend" OFF)
37-
option(RECONVERSE_AUTOFETCH_LCI1
38-
"whether to autofetch LCIv1 if LCI1 cannot be found" OFF)
39-
set(RECONVERSE_AUTOFETCH_LCI1_TAG
40-
"ad1c43e5ff28bb2cfc8a300615f4d502b7bce31f"
41-
CACHE STRING "The tag to fetch for LCIv1") # master branch as of 2025-04-17
42-
4336
option(SPANTREE "whether to enable spanning tree collectives" ON)
4437
option(CMK_SMP "whether to enable SMP support" ON)
4538

src/comm_backend/CMakeLists.txt

+1-54
Original file line numberDiff line numberDiff line change
@@ -61,57 +61,4 @@ if(RECONVERSE_TRY_ENABLE_COMM_LCI2)
6161
"LCI2 is not found. The LCI2 backend is not enabled. Try setting RECONVERSE_AUTOFETCH_LCI2=ON to fetch LCIv2 automatically."
6262
)
6363
endif()
64-
endif()
65-
66-
# LCI1
67-
if(NOT RECONVERSE_ENABLE_COMM_LCI2 AND RECONVERSE_TRY_ENABLE_COMM_LCI1)
68-
# Try to find LCIv1 externally
69-
find_package(
70-
LCI
71-
CONFIG
72-
HINTS
73-
${LCI_ROOT}
74-
$ENV{LCI_ROOT}
75-
PATH_SUFFIXES
76-
lib/cmake
77-
lib64/cmake)
78-
if(LCI_FOUND
79-
AND NOT LCI_WITH_LCT_ONLY
80-
AND LCI_VERSION VERSION_LESS 2.0.0)
81-
set(RECONVERSE_ENABLE_COMM_LCI1 ON)
82-
endif()
83-
84-
if(NOT RECONVERSE_ENABLE_COMM_LCI1 AND RECONVERSE_AUTOFETCH_LCI1)
85-
if(FETCHCONTENT_SOURCE_DIR_LCI)
86-
message(
87-
STATUS
88-
"LCI will be include through FetchContent from ${FETCHCONTENT_SOURCE_DIR_LCI}"
89-
)
90-
else()
91-
message(
92-
STATUS
93-
"LCI will be include throught FetchContent from GIT_TAG ${RECONVERSE_AUTOFETCH_LCI1_TAG}"
94-
)
95-
endif()
96-
include(FetchContent)
97-
FetchContent_Declare(
98-
lci
99-
GIT_REPOSITORY https://github.com/uiuc-hpc/lci.git
100-
GIT_TAG ${RECONVERSE_AUTOFETCH_LCI1_TAG})
101-
FetchContent_MakeAvailable(lci)
102-
set(RECONVERSE_ENABLE_COMM_LCI1 ON)
103-
endif()
104-
105-
if(RECONVERSE_ENABLE_COMM_LCI1)
106-
message(STATUS "LCIv1 found. Enabling LCIv1 backend.")
107-
message(WARNING "LCIv1 is deprecated. Please use LCIv2 instead.")
108-
target_link_libraries(reconverse PRIVATE LCI::LCI)
109-
target_sources(reconverse PRIVATE lci1/comm_backend_lci1.cpp)
110-
set(RECONVERSE_ENABLE_COMM_LCI1 ON PARENT_SCOPE)
111-
else()
112-
message(
113-
WARNING
114-
"LCIv1 is not found. The LCIv1 backend is not enabled. Try setting RECONVERSE_AUTOFETCH_LCI1=ON to fetch LCIv1 automatically."
115-
)
116-
endif()
117-
endif()
64+
endif()

src/comm_backend/comm_backend_internal.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ int gMyNodeID = 0;
99
void init(int *argc, char ***argv) {
1010
#ifdef RECONVERSE_ENABLE_COMM_LCI2
1111
gCommBackend = new CommBackendLCI2();
12-
#elif defined(RECONVERSE_ENABLE_COMM_LCI1)
13-
gCommBackend = new CommBackendLCI1();
1412
#endif
1513
if (gCommBackend == nullptr) {
1614
return;

src/comm_backend/comm_backend_internal.h

-3
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,5 @@ class CommBackendBase {
3838
#ifdef RECONVERSE_ENABLE_COMM_LCI2
3939
#include "comm_backend/lci2/comm_backend_lci2.h"
4040
#endif
41-
#ifdef RECONVERSE_ENABLE_COMM_LCI1
42-
#include "comm_backend/lci1/comm_backend_lci1.h"
43-
#endif
4441

4542
#endif // COMM_BACKEND_INTERNAL_H

src/comm_backend/lci1/comm_backend_lci1.cpp

-133
This file was deleted.

src/comm_backend/lci1/comm_backend_lci1.h

-30
This file was deleted.

src/converse_config.h.in

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#define CONVERSE_CONFIG_H
33

44
#cmakedefine RECONVERSE_ENABLE_COMM_LCI2
5-
#cmakedefine RECONVERSE_ENABLE_COMM_LCI1
65
#cmakedefine SPANTREE
76
#cmakedefine CMK_SMP
87

0 commit comments

Comments
 (0)