Handle missing contact form item tag labels (#1478)

Co-authored-by: Test <test@test.com>

Author: stefan-burke

src/_lib/config/form-helpers.js

@@ -27,7 +27,7 @@
 /**
  * @typedef {object} ContactFormData
  * @property {ContactFormField[]} fields
- * @property {Record<string, string>} itemTagLabels
+ * @property {Record<string, string>} [itemTagLabels]
  */
 
 /**
@@ -45,8 +45,9 @@
  * @returns {ContactFormField[]}
  */
 export function resolveFormFields(contactForm, tags, skipShowOn = false) {
+  const { fields, itemTagLabels = {} } = contactForm;
   const tagList = Array.isArray(tags) ? tags : [];
-  const matchEntry = Object.entries(contactForm.itemTagLabels).find(([tag]) =>
+  const matchEntry = Object.entries(itemTagLabels).find(([tag]) =>
     tagList.includes(tag),
   );
   const match = matchEntry
@@ -83,7 +84,7 @@ export function resolveFormFields(contactForm, tags, skipShowOn = false) {
     return [field];
   };
 
-  return contactForm.fields.flatMap(resolveField);
+  return fields.flatMap(resolveField);
 }
 
 /**

test/unit/contact-form-fields.test.js

@@ -93,4 +93,10 @@ describe("resolveFormFields", () => {
     // showForItemTag field is dropped (no match), plain fields pass through
     expect(out.map((f) => f.name)).toEqual(["name", "message"]);
   });
+
+  test("treats missing item tag labels as an empty mapping", () => {
+    const contactForm = { fields: baseContactForm.fields };
+    const out = resolveFormFields(contactForm, ["products"]);
+    expect(out.map((f) => f.name)).toEqual(["name", "message"]);
+  });
 });